From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Wolfram Sang <w.sang@pengutronix.de>
Cc: Heiko Stuebner <heiko@sntech.de>, Liam Girdwood <lrg@ti.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] regulator: gpio-regulator: Basic devm_kzalloc() conversion
Date: Wed, 4 Apr 2012 10:45:24 +0100 [thread overview]
Message-ID: <20120404094524.GA3002@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <20120404065015.GA24930@pengutronix.de>
[-- Attachment #1: Type: text/plain, Size: 467 bytes --]
On Wed, Apr 04, 2012 at 08:50:15AM +0200, Wolfram Sang wrote:
> On Tue, Apr 03, 2012 at 11:23:09PM +0100, Mark Brown wrote:
> > There's some other allocations but they're not so trivial as they use
> > kmemdup() and kstrdup().
> What do we gain then? I wonder if it is worth fixing one occasion if we can't
> fix the others (yet).
I probably wouldn't have bothered if I'd noticed the other allocations
before I wrote the code but as I'd already written the code...
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
prev parent reply other threads:[~2012-04-04 9:45 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-03 22:23 [PATCH 1/2] regulator: gpio-regulator: Sort in Makefile Mark Brown
2012-04-03 22:23 ` [PATCH 2/2] regulator: gpio-regulator: Basic devm_kzalloc() conversion Mark Brown
2012-04-04 6:50 ` Wolfram Sang
2012-04-04 9:45 ` Mark Brown [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120404094524.GA3002@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=heiko@sntech.de \
--cc=linux-kernel@vger.kernel.org \
--cc=lrg@ti.com \
--cc=w.sang@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.