From: Andy Whitcroft <apw@canonical.com>
To: "Luis R. Rodriguez" <mcgrof@frijolero.org>
Cc: "Luis R. Rodriguez" <mcgrof@bombadil.infradead.org>,
hauke@hauke-m.de, linux-wireless@vger.kernel.org,
linux-kernel@vger.kernel.org, kernel-team@lists.ubuntu.com,
lf_driver_backport@lists.linux-foundation.org
Subject: Re: [PATCH] compat: add compat kernel checker and downloader
Date: Wed, 4 Apr 2012 12:10:14 +0100 [thread overview]
Message-ID: <20120404111014.GB3378@shadowen.org> (raw)
In-Reply-To: <CAB=NE6U_Sq88ro7onChn8U4tkkqt7Z9YN9wMyZjx+78j+M=_uA@mail.gmail.com>
On Fri, Mar 30, 2012 at 05:23:46PM -0700, Luis R. Rodriguez wrote:
> Andy, so I just noticed that on all Ubuntu PPA (and generic) kernels
> you guys have a broken symlink >= 2.6.33.
>
> /lib/modules/2.6.33-02063305-generic/build/include/asm
>
> points to asm-x86 and that is no longer present after 2.6.33 so any
> module requiring those header files will break now on Ubuntu. I just
> spotted this as some file from asm is now included in the modules were
> are building. I guess not many external kernel modules include asm dir
> otherwise you guys would have noticed this a long time ago.
Luis, I concur that the link is now broken. However that link is actually
simply superfulous now. Anything correctly using kernel 'external
module' support will be using the -I path from the kernel Makefiles.
They will therefore be including from /usr/src/<version>/include _and_
/usr/src/<version>/arch/x86/include. I presume this is why we have not
noticed it.
I will get that link removed however as it is simply bogus.
-apw
next prev parent reply other threads:[~2012-04-04 11:10 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-03 23:43 [PATCH] compat: add compat kernel checker and downloader Luis R. Rodriguez
2012-02-06 10:57 ` Andy Whitcroft
2012-02-06 16:07 ` John W. Linville
2012-02-07 4:19 ` Luis R. Rodriguez
2012-02-07 4:56 ` Luis R. Rodriguez
2012-02-08 1:19 ` Luis R. Rodriguez
2012-02-08 2:55 ` Luis R. Rodriguez
2012-02-08 2:58 ` Luis R. Rodriguez
2012-03-31 0:23 ` Luis R. Rodriguez
2012-04-04 11:10 ` Andy Whitcroft [this message]
2012-04-05 20:19 ` Tim Gardner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120404111014.GB3378@shadowen.org \
--to=apw@canonical.com \
--cc=hauke@hauke-m.de \
--cc=kernel-team@lists.ubuntu.com \
--cc=lf_driver_backport@lists.linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=mcgrof@bombadil.infradead.org \
--cc=mcgrof@frijolero.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.