All of lore.kernel.org
 help / color / mirror / Atom feed
From: Johan Hedberg <johan.hedberg@gmail.com>
To: Claudio Takahasi <claudio.takahasi@openbossa.org>
Cc: linux-bluetooth@vger.kernel.org
Subject: Re: [RFC BlueZ 1/4] Add Bluetooth address type in sockaddr_l2
Date: Thu, 5 Apr 2012 13:30:11 +0300	[thread overview]
Message-ID: <20120405103011.GF32212@x220> (raw)
In-Reply-To: <1333570571-29650-1-git-send-email-claudio.takahasi@openbossa.org>

Hi Claudio,

On Wed, Apr 04, 2012, Claudio Takahasi wrote:
> This patch adds the address type information to sockaddr_l2 structure,
> allowing the userspace to inform the remote address type required for
> LE Create Connection command.
> ---
>  lib/l2cap.h |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
> 
> diff --git a/lib/l2cap.h b/lib/l2cap.h
> index 5806aaa..5ce94c4 100644
> --- a/lib/l2cap.h
> +++ b/lib/l2cap.h
> @@ -43,6 +43,7 @@ struct sockaddr_l2 {
>  	unsigned short	l2_psm;
>  	bdaddr_t	l2_bdaddr;
>  	unsigned short	l2_cid;
> +	uint8_t		l2_bdaddr_type;
>  };
>  
>  /* L2CAP socket options */

To answer my question about what defines/enum values are passed to the
BtIO API, this patch should probably be adding the same BDADDR_* defines
that Andre's patch 2/5 is adding on the kernel side, and then your BtIO
patch should use BDADDR_BREDR to initialize opts->dst_type.

Johan

  parent reply	other threads:[~2012-04-05 10:30 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-04-04 20:16 [RFC BlueZ 1/4] Add Bluetooth address type in sockaddr_l2 Claudio Takahasi
2012-04-04 20:16 ` [RFC BlueZ 2/4] btio: Add address type in bt_io_connect Claudio Takahasi
2012-04-05 10:28   ` Johan Hedberg
2012-04-05 22:38     ` [RFC BlueZ v1 2/7] " Claudio Takahasi
2012-04-04 20:16 ` [RFC BlueZ 3/4] Add address type for BLE bt_io_connect calls Claudio Takahasi
2012-04-05 22:38   ` [RFC BlueZ v1 3/7] " Claudio Takahasi
2012-04-04 20:16 ` [RFC BlueZ 4/4] l2test: Add option to inform the address type Claudio Takahasi
2012-04-05  6:35   ` Andrei Emeltchenko
2012-04-05 22:38     ` [RFC BlueZ v1 7/7] " Claudio Takahasi
2012-04-05 23:17     ` [RFC BlueZ 4/4] " Andre Guedes
2012-04-05 10:30 ` Johan Hedberg [this message]
2012-04-05 22:38   ` [RFC BlueZ v1 1/7] Add Bluetooth address type in sockaddr_l2 Claudio Takahasi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120405103011.GF32212@x220 \
    --to=johan.hedberg@gmail.com \
    --cc=claudio.takahasi@openbossa.org \
    --cc=linux-bluetooth@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.