All of lore.kernel.org
 help / color / mirror / Atom feed
From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Florian Westphal <fw@strlen.de>
Cc: netfilter-devel@vger.kernel.org
Subject: Re: [PATCH -next] netfilter: bridge: optionally set indev to vlan
Date: Thu, 5 Apr 2012 13:09:36 +0200	[thread overview]
Message-ID: <20120405110936.GA8098@1984> (raw)
In-Reply-To: <20120405073059.GD23461@Chamillionaire.breakpoint.cc>

On Thu, Apr 05, 2012 at 09:30:59AM +0200, Florian Westphal wrote:
> Pablo Neira Ayuso <pablo@netfilter.org> wrote:
> > On Wed, Apr 04, 2012 at 09:57:29PM +0200, Florian Westphal wrote:
> > > if net.bridge.bridge-nf-filter-vlan-tagged sysctl is enabled, bridge
> > > netfilter removes the vlan header temporarily and then feeds the packet
> > > to ip(6)tables.
> > > 
> > > When the new "bridge-nf-pass-vlan-input-device" sysctl is on
> > > (default off), then bridge netfilter will also change the in/out
> > > interface to the vlan interface; if such an interface exists.
> > > 
> > > This is needed to make iptables REDIRECT target work with
> > > "vlan-on-top-of-bridge" setups. Also, 'iptables -i' can then be used
> > > to match the vlan device name.
> > > 
> > > Also update Documentation with current brnf default settings.
> > 
> > Better to implement a vlan device match for iptables?
> 
> That would mean that REDIRECT target is unsupported in vlan-on-bridge
> case.

I see, it would not support any other targets that relies on skb->dev
either.

Let me think if I can come with a better solution. If not, I'll take
your patch.

Thanks Florian.

  reply	other threads:[~2012-04-05 11:09 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-04-04 19:57 [PATCH -next] netfilter: bridge: optionally set indev to vlan Florian Westphal
2012-04-05  1:09 ` Pablo Neira Ayuso
2012-04-05  7:30   ` Florian Westphal
2012-04-05 11:09     ` Pablo Neira Ayuso [this message]
2012-04-05 17:20 ` Bart De Schuymer
2012-04-05 19:40   ` Florian Westphal

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120405110936.GA8098@1984 \
    --to=pablo@netfilter.org \
    --cc=fw@strlen.de \
    --cc=netfilter-devel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.