From: Marek Vasut <marex@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] i.MX28: Enable SD DMA only if DCache enabled
Date: Thu, 5 Apr 2012 12:08:27 +0200 [thread overview]
Message-ID: <201204051208.27893.marex@denx.de> (raw)
In-Reply-To: <CAOMZO5C5rL4gFDBC=P4EcUvuK2u1jCN5PHsDTqHQ4VYpd3MYYw@mail.gmail.com>
Dear Fabio Estevam,
> On Wed, Apr 4, 2012 at 9:48 PM, Marek Vasut <marex@denx.de> wrote:
> >> Someone may want to enable cache, but still uses MMC driver in PIO mode.
> >
> > You don't, it's slow as crap then.
>
> Well, this is how we have been using the MMC driver for the last 4 months.
With DCache disabled though ;-)
> I like the fact that your patch let PIO and DMA mode co-exist in the
> driver and that they are selectable by the CONFIG_MXS_MMC_DMA option.
>
> What I really don?t like is that by enabling CONFIG_SYS_DCACHE_OFF you
> force CONFIG_MXS_MMC_DMA.
All right, agreed.
> These are separate things and one config option should not force the other.
Best regards,
Marek Vasut
next prev parent reply other threads:[~2012-04-05 10:08 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-04 21:51 [U-Boot] [PATCH] i.MX28: Enable SD DMA only if DCache enabled Marek Vasut
2012-04-04 23:12 ` Fabio Estevam
2012-04-05 0:48 ` Marek Vasut
2012-04-05 3:36 ` Fabio Estevam
2012-04-05 10:08 ` Marek Vasut [this message]
2012-04-06 0:34 ` Fabio Estevam
2012-04-06 1:03 ` Marek Vasut
2012-04-05 10:24 ` [U-Boot] [PATCH] i.MX28: Allow coexistence of PIO and DMA mode for SD/MMC Marek Vasut
2012-04-05 12:12 ` Stefano Babic
2012-04-05 12:17 ` Marek Vasut
2012-04-05 12:28 ` Stefano Babic
2012-04-05 13:30 ` [U-Boot] [PATCH V3] " Marek Vasut
2012-04-09 10:57 ` Stefano Babic
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201204051208.27893.marex@denx.de \
--to=marex@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.