From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Marc Kleine-Budde <mkl@pengutronix.de>
Cc: joancarles@fqingenieria.es,
Fabio Estevam <fabio.estevam@freescale.com>,
alsa-devel@alsa-project.org, Fabio Estevam <festevam@gmail.com>,
kernel@pengutronix.de
Subject: Re: [PATCH 2/2] ASoC: imx-audmux: Check for NULL pointer
Date: Thu, 5 Apr 2012 13:55:02 +0100 [thread overview]
Message-ID: <20120405125501.GL3129@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <4F7D94CC.80300@pengutronix.de>
[-- Attachment #1.1: Type: text/plain, Size: 401 bytes --]
On Thu, Apr 05, 2012 at 02:49:16PM +0200, Marc Kleine-Budde wrote:
> On 04/05/2012 02:45 PM, Fabio Estevam wrote:
> > if (audmux_clk)
> > clk_prepare_enable(audmux_clk);
> > + if (!audmux_base)
> > + return -ENOSYS;
> What about "clk_prepare_enable"? Do you need to undo it in case of an error?
Or alternatively just reverse the order of the two tests so you don't
need to worry about that.
[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
[-- Attachment #2: Type: text/plain, Size: 0 bytes --]
next prev parent reply other threads:[~2012-04-05 12:55 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-05 12:45 [PATCH 1/2] ASoC: imx-audmux: Fix ssi port numbers in sysfs Fabio Estevam
2012-04-05 12:45 ` [PATCH 2/2] ASoC: imx-audmux: Check for NULL pointer Fabio Estevam
[not found] ` <4F7D94CC.80300@pengutronix.de>
2012-04-05 12:55 ` Mark Brown [this message]
2012-04-05 14:25 ` [PATCH 1/2] ASoC: imx-audmux: Fix ssi port numbers in sysfs Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120405125501.GL3129@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=alsa-devel@alsa-project.org \
--cc=fabio.estevam@freescale.com \
--cc=festevam@gmail.com \
--cc=joancarles@fqingenieria.es \
--cc=kernel@pengutronix.de \
--cc=mkl@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.