From: "Michael S. Tsirkin" <mst@redhat.com>
To: Alex Williamson <alex.williamson@redhat.com>
Cc: kvm@vger.kernel.org, jan.kiszka@siemens.com, jbaron@redhat.com
Subject: Re: [PATCH v2] kvm: Disable MSI/MSI-X in assigned device reset path
Date: Thu, 5 Apr 2012 18:04:23 +0300 [thread overview]
Message-ID: <20120405150422.GA1089@redhat.com> (raw)
In-Reply-To: <1333636923.2427.13.camel@ul30vt>
On Thu, Apr 05, 2012 at 08:42:03AM -0600, Alex Williamson wrote:
> > So far so good.
> >
> > > + * We especially do not want MSI-X
> > > + * enabled since it lives in MMIO space, which is about to get
> > > + * disabled.
> >
> > I think we are better off dropping the above, because it's
> > a bug that we disable MMIO space on the physical device:
> > we did not enable it (kvm did) let's not disable.
>
> I'd like to investigate removing the command register clearing, but it
> did solve a bug at the time it went in. That will be a separate patch,
> so we can remove the above sentence when that's removed. It may be a
> bug, but it's describing the current behavior.
Fair enough.
Acked-by: Michael S. Tsirkin <mst@redhat.com>
next prev parent reply other threads:[~2012-04-05 15:04 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-05 3:42 [PATCH v2] kvm: Disable MSI/MSI-X in assigned device reset path Alex Williamson
2012-04-05 7:28 ` Jan Kiszka
2012-04-05 9:34 ` Michael S. Tsirkin
2012-04-05 14:42 ` Alex Williamson
2012-04-05 15:04 ` Michael S. Tsirkin [this message]
2012-04-08 13:14 ` Avi Kivity
2012-04-08 13:17 ` Michael S. Tsirkin
2012-04-08 13:18 ` Avi Kivity
2012-04-08 13:21 ` Michael S. Tsirkin
2012-04-08 13:24 ` Avi Kivity
2012-04-08 13:30 ` Michael S. Tsirkin
2012-04-08 13:41 ` Avi Kivity
2012-04-08 13:53 ` Michael S. Tsirkin
2012-04-08 14:01 ` Avi Kivity
2012-04-08 14:42 ` Michael S. Tsirkin
2012-04-08 15:26 ` Avi Kivity
2012-04-08 15:46 ` Michael S. Tsirkin
2012-04-08 15:50 ` Avi Kivity
2012-04-08 16:04 ` Michael S. Tsirkin
2012-04-08 16:08 ` Avi Kivity
2012-04-08 17:37 ` Jan Kiszka
2012-04-08 18:18 ` Michael S. Tsirkin
2012-04-08 18:39 ` Jan Kiszka
2012-04-08 20:35 ` Michael S. Tsirkin
2012-04-09 8:35 ` Avi Kivity
2012-04-10 16:55 ` Alex Williamson
2012-04-16 14:03 ` Alex Williamson
2012-04-16 14:31 ` Avi Kivity
2012-04-16 15:06 ` Michael S. Tsirkin
2012-04-16 15:10 ` Jan Kiszka
2012-04-16 16:08 ` Michael S. Tsirkin
2012-04-16 16:13 ` Jan Kiszka
2012-04-16 16:36 ` Michael S. Tsirkin
2012-04-16 16:38 ` Jan Kiszka
2012-04-16 17:12 ` Michael S. Tsirkin
2012-04-16 18:47 ` Jan Kiszka
2012-04-16 16:12 ` Jason Baron
2012-04-16 16:34 ` Michael S. Tsirkin
2012-04-16 19:07 ` Alex Williamson
2012-04-16 19:47 ` Michael S. Tsirkin
2012-04-17 0:55 ` Marcelo Tosatti
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120405150422.GA1089@redhat.com \
--to=mst@redhat.com \
--cc=alex.williamson@redhat.com \
--cc=jan.kiszka@siemens.com \
--cc=jbaron@redhat.com \
--cc=kvm@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.