All of lore.kernel.org
 help / color / mirror / Atom feed
From: Marek Vasut <marex@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [REFERENCE DON'T APPLY 1/3] dfu: Add default value for bwPollTimeout
Date: Fri, 6 Apr 2012 02:18:16 +0200	[thread overview]
Message-ID: <201204060218.16728.marex@denx.de> (raw)
In-Reply-To: <1333465497-29909-1-git-send-email-stefan@datenfreihafen.org>

Dear Stefan Schmidt,

Nice stuff, can you CC me when it comes to USB stuff, accidentally I became the 
new maintainer ? ;-)

> ---
>  drivers/usb/gadget/dfu.c |   11 ++++++++++-
>  1 file changed, 10 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/usb/gadget/dfu.c b/drivers/usb/gadget/dfu.c
> index 535e194..7aed344 100644
> --- a/drivers/usb/gadget/dfu.c
> +++ b/drivers/usb/gadget/dfu.c
> @@ -47,6 +47,10 @@
>  #include <malloc.h>
>  #include "dfu.h"
> 
> +#ifndef POLL_TIMEOUT_MILLISECONDS
> +#define POLL_TIMEOUT_MILLISECONDS 5
> +#endif
> +
>  static struct flash_entity *flash_ents;
>  static int num_flash_ents;
> 
> @@ -271,9 +275,14 @@ static void handle_getstatus(struct usb_request *req)
> 
>  	/* send status response */
>  	dstat->bStatus = dev->dfu_status;
> -	/* FIXME: set dstat->bwPollTimeout */
>  	dstat->bState = dev->dfu_state;
>  	dstat->iString = 0;
> +	/* FIXME: Use real values from flash subsystem here instead a hardcoded
> +	 * value */
> +	dstat->bwPollTimeout[0] = POLL_TIMEOUT_MILLISECONDS & 0xff;
> +	dstat->bwPollTimeout[1] = (POLL_TIMEOUT_MILLISECONDS >> 8) & 0xff;
> +	dstat->bwPollTimeout[2] = (POLL_TIMEOUT_MILLISECONDS >> 16) & 0xff;
> +	//req->actual = MIN(sizeof(*dstat), max);

What do you expect from me to tell you about this patch? Or do you expect 
someone else to comment on this?

>  }
> 
>  static void handle_getstate(struct usb_request *req)

Best regards,
Marek Vasut

  parent reply	other threads:[~2012-04-06  0:18 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-11-09  9:52 [U-Boot] [PATCH v2 0/4] DFU initial implementation Andrzej Pietrasiewicz
2011-11-09  9:52 ` [U-Boot] [PATCH 1/4] dfu: protocol " Andrzej Pietrasiewicz
2011-11-09  9:52 ` [U-Boot] [PATCH 2/4] dfu: generic backend parts Andrzej Pietrasiewicz
2012-01-08  5:13   ` Mike Frysinger
2012-01-09  7:50     ` Andrzej Pietrasiewicz
2012-01-09 17:26       ` Mike Frysinger
2012-03-18 18:49       ` Wolfgang Denk
2012-04-03 14:56       ` Stefan Schmidt
2012-04-03 15:04         ` [U-Boot] [REFERENCE DON'T APPLY 1/3] dfu: Add default value for bwPollTimeout Stefan Schmidt
2012-04-03 15:04           ` [U-Boot] [REFERENCE DON'T APPLY 2/3] usb/gadget: Add Device Firmware Upgrade (DFU) support Stefan Schmidt
2012-04-03 15:04           ` [U-Boot] [REFERENCE DON'T APPLY 3/3] beagle: Enable DFU support with stub functions for now Stefan Schmidt
2012-04-06  0:18           ` Marek Vasut [this message]
2012-04-06  3:35             ` [U-Boot] [REFERENCE DON'T APPLY 1/3] dfu: Add default value for bwPollTimeout Mike Frysinger
2012-04-06 13:06               ` Marek Vasut
2012-04-21 14:30                 ` Stefan Schmidt
2012-04-21 15:38                   ` Marek Vasut
2012-04-23  7:27                     ` Lukasz Majewski
2012-04-23  9:38                       ` Marek Vasut
2012-04-24 19:40                       ` Stefan Schmidt
2012-04-21 14:28             ` Stefan Schmidt
2011-11-09  9:52 ` [U-Boot] [PATCH 3/4] dfu: command implementation Andrzej Pietrasiewicz
2011-11-09  9:52 ` [U-Boot] [PATCH 4/4] dfu: target-specific implementation for Goni Andrzej Pietrasiewicz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201204060218.16728.marex@denx.de \
    --to=marex@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.