From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Axel Lin <axel.lin@gmail.com>
Cc: linux-kernel@vger.kernel.org,
Laxman Dewangan <ldewangan@nvidia.com>,
Liam Girdwood <lrg@ti.com>
Subject: Re: [PATCH RFT 2/2] regulator: Convert rc5t583 to set_voltage
Date: Fri, 6 Apr 2012 18:32:59 +0100 [thread overview]
Message-ID: <20120406173258.GM19424@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <1333606056.18055.3.camel@phoenix>
[-- Attachment #1: Type: text/plain, Size: 410 bytes --]
On Thu, Apr 05, 2012 at 02:07:36PM +0800, Axel Lin wrote:
> Not every regulator driver should implement set_voltage_sel callback.
> See commit e8eef82
> "regulator: Provide a selector based set_voltage_sel() operation".
>
> For rc5t583, the regulator voltage can be mapped onto selector values with a
> simple calculation, thus implement set_voltage is better than set_voltage_sel.
Applied, thanks.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2012-04-06 17:33 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-05 6:04 [PATCH 1/2] regulator: rc5t583: Remove nsteps from struct rc5t583_regulator_info Axel Lin
2012-04-05 6:07 ` [PATCH RFT 2/2] regulator: Convert rc5t583 to set_voltage Axel Lin
2012-04-05 7:01 ` Laxman Dewangan
2012-04-05 9:47 ` Mark Brown
2012-04-06 17:32 ` Mark Brown [this message]
2012-04-05 6:58 ` [PATCH 1/2] regulator: rc5t583: Remove nsteps from struct rc5t583_regulator_info Laxman Dewangan
2012-04-05 10:07 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120406173258.GM19424@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=axel.lin@gmail.com \
--cc=ldewangan@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lrg@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.