From: Grant Likely <grant.likely@secretlab.ca>
To: Mark Brown <broonie@opensource.wolfsonmicro.com>
Cc: Linus Walleij <linus.walleij@stericsson.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] gpiolib: Implement devm_gpio_request_one()
Date: Fri, 06 Apr 2012 19:25:12 -0700 [thread overview]
Message-ID: <20120407022512.2C65C3E1B12@localhost> (raw)
In-Reply-To: <20120406144917.GE19424@opensource.wolfsonmicro.com>
On Fri, 6 Apr 2012 15:49:17 +0100, Mark Brown <broonie@opensource.wolfsonmicro.com> wrote:
> On Thu, Apr 05, 2012 at 09:48:32PM -0700, Grant Likely wrote:
>
> > Can we make devm_gpio_request a static inline wrapper around
> > devm_gpio_request_one() with the flags field set to '0'? I don't liek
> > the duplication of this function.
>
> > Similarily, gpio_request() should actually be a static inline around
> > gpio_request_one() instead of the other way around as it is currently
> > written.
>
> Yeah, I couldn't understand why the non-managed functions were written
> in this way so I followed the same pattern when I added the managed one
> assuming that the original code was sane.
Actually, I looked at it again, and the _one version behaves subtly
different from the non-_one version. That may be irrelevant though.
g.
--
Grant Likely, B.Sc, P.Eng.
Secret Lab Technologies,Ltd.
next prev parent reply other threads:[~2012-04-07 7:11 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-04 15:14 [PATCH 1/2] gpiolib: Add !CONFIG_GPIOLIB definitions of devm_ functions Mark Brown
2012-04-04 15:14 ` [PATCH 2/2] gpiolib: Implement devm_gpio_request_one() Mark Brown
2012-04-06 4:48 ` Grant Likely
2012-04-06 14:49 ` Mark Brown
2012-04-07 2:25 ` Grant Likely [this message]
2012-04-07 9:00 ` Mark Brown
2012-04-07 9:16 ` Mark Brown
2012-04-06 4:40 ` [PATCH 1/2] gpiolib: Add !CONFIG_GPIOLIB definitions of devm_ functions Grant Likely
-- strict thread matches above, loose matches on Subject: below --
2012-05-02 11:46 Mark Brown
2012-05-02 11:46 ` [PATCH 2/2] gpiolib: Implement devm_gpio_request_one() Mark Brown
2012-05-12 19:05 ` Mark Brown
2012-05-18 0:10 ` Grant Likely
2012-05-12 23:19 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120407022512.2C65C3E1B12@localhost \
--to=grant.likely@secretlab.ca \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=linus.walleij@stericsson.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.