On Fri, Apr 06, 2012 at 07:25:12PM -0700, Grant Likely wrote: > On Fri, 6 Apr 2012 15:49:17 +0100, Mark Brown wrote: > > Yeah, I couldn't understand why the non-managed functions were written > > in this way so I followed the same pattern when I added the managed one > > assuming that the original code was sane. > Actually, I looked at it again, and the _one version behaves subtly > different from the non-_one version. That may be irrelevant though. It always does a direction set, yes. This will make a difference if the direction call either fails or blocks future reconfigurations, what was puzzling me was if this was an issue or not and like I say I decided to assume it was and stick with the same pattern.