diff for duplicates of <20120409151605.GA6482@fieldses.org> diff --git a/a/1.txt b/N1/1.txt index b7f011a..0be21d2 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -1,70 +1,59 @@ On Wed, Apr 04, 2012 at 02:16:22PM -0400, Josef Bacik wrote: > On Wed, Apr 04, 2012 at 09:12:57PM +0300, Kasatkin, Dmitry wrote: -> > On Wed, Apr 4, 2012 at 8:47 PM, Mimi Zohar <zohar@linux.vnet.ibm.co= -m> wrote: +> > On Wed, Apr 4, 2012 at 8:47 PM, Mimi Zohar <zohar@linux.vnet.ibm.com> wrote: > > > On Wed, 2012-04-04 at 13:43 -0400, Josef Bacik wrote: -> > >> On Wed, Apr 04, 2012 at 08:24:19PM +0300, Kasatkin, Dmitry wrote= -: +> > >> On Wed, Apr 04, 2012 at 08:24:19PM +0300, Kasatkin, Dmitry wrote: > > >> > Hello, > > >> > > > >> > Mimi and I working on IMA/EVM (security/integrity) and it uses > > >> > i_version for checking if file content has been changed. -> > >> > extX file systems support i_version updates with mounting file= - system +> > >> > extX file systems support i_version updates with mounting file system > > >> > with "iversion" option or via kernel command line parameter > > >> > "i_version" > > >> > -> > >> > It seems iversion option is not recognized when mounting btrfs= -=2E +> > >> > It seems iversion option is not recognized when mounting btrfs. > > >> > I see this patchset deals with i_version update as well.. > > >> > Can you please give an advice how to use i_version with btrfs? > > >> > > > >> -> > >> Oh good somebody uses this? =C2=A0We actually have a ->sequence = -thing we use for -> > >> this, the grand idea was to make it smarter about telling nfs wh= -en something -> > >> changed, but if you guys use i_version we could probably get rid= - of our in-core -> > >> sequence and use the normal inodes i_version and then just store= - it in our -> > >> sequence field on disk. =C2=A0I'll do it without a mount option = -tho so it just works, -> > >> does that sound good to you? =C2=A0Thanks, -> >=20 +> > >> Oh good somebody uses this? We actually have a ->sequence thing we use for +> > >> this, the grand idea was to make it smarter about telling nfs when something +> > >> changed, but if you guys use i_version we could probably get rid of our in-core +> > >> sequence and use the normal inodes i_version and then just store it in our +> > >> sequence field on disk. I'll do it without a mount option tho so it just works, +> > >> does that sound good to you? Thanks, +> > > > Hello, -> >=20 +> > > > Thank you for the answer... > > But can you a bit clarify... -> >=20 +> > > > Looking to file_update_time() I see that it does: -> >=20 +> > > > if (IS_I_VERSION(inode)) -> > sync_it |=3D S_VERSION; -> >=20 +> > sync_it |= S_VERSION; +> > > > Basically it should be (inode->i_sb->s_flags & MS_I_VERSION) -> >=20 +> > > > use of i_version is controlled by iversion mount flag. > > for ext4 I see in parse_options(): -> >=20 +> > > > case Opt_i_version: > > set_opt(sb, I_VERSION); -> > sb->s_flags |=3D MS_I_VERSION; +> > sb->s_flags |= MS_I_VERSION; > > break; -> >=20 -> >=20 +> > +> > > > But who sets MS_I_VERSION in s_flags on btrfs? -> >=20 ->=20 -> Nobody yet, I'm going to send a patch shortly that will support this.= - Thanks, +> > +> +> Nobody yet, I'm going to send a patch shortly that will support this. Thanks, Great. It would also be far preferable if it was just always on (at least by default) rather than requiring a mount option. --b. -- -To unsubscribe from this list: send the line "unsubscribe linux-btrfs" = -in +To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/a/content_digest b/N1/content_digest index 9fcd666..217ae0e 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -20,73 +20,62 @@ "b\0" "On Wed, Apr 04, 2012 at 02:16:22PM -0400, Josef Bacik wrote:\n" "> On Wed, Apr 04, 2012 at 09:12:57PM +0300, Kasatkin, Dmitry wrote:\n" - "> > On Wed, Apr 4, 2012 at 8:47 PM, Mimi Zohar <zohar@linux.vnet.ibm.co=\n" - "m> wrote:\n" + "> > On Wed, Apr 4, 2012 at 8:47 PM, Mimi Zohar <zohar@linux.vnet.ibm.com> wrote:\n" "> > > On Wed, 2012-04-04 at 13:43 -0400, Josef Bacik wrote:\n" - "> > >> On Wed, Apr 04, 2012 at 08:24:19PM +0300, Kasatkin, Dmitry wrote=\n" - ":\n" + "> > >> On Wed, Apr 04, 2012 at 08:24:19PM +0300, Kasatkin, Dmitry wrote:\n" "> > >> > Hello,\n" "> > >> >\n" "> > >> > Mimi and I working on IMA/EVM (security/integrity) and it uses\n" "> > >> > i_version for checking if file content has been changed.\n" - "> > >> > extX file systems support i_version updates with mounting file=\n" - " system\n" + "> > >> > extX file systems support i_version updates with mounting file system\n" "> > >> > with \"iversion\" option or via kernel command line parameter\n" "> > >> > \"i_version\"\n" "> > >> >\n" - "> > >> > It seems iversion option is not recognized when mounting btrfs=\n" - "=2E\n" + "> > >> > It seems iversion option is not recognized when mounting btrfs.\n" "> > >> > I see this patchset deals with i_version update as well..\n" "> > >> > Can you please give an advice how to use i_version with btrfs?\n" "> > >> >\n" "> > >>\n" - "> > >> Oh good somebody uses this? =C2=A0We actually have a ->sequence =\n" - "thing we use for\n" - "> > >> this, the grand idea was to make it smarter about telling nfs wh=\n" - "en something\n" - "> > >> changed, but if you guys use i_version we could probably get rid=\n" - " of our in-core\n" - "> > >> sequence and use the normal inodes i_version and then just store=\n" - " it in our\n" - "> > >> sequence field on disk. =C2=A0I'll do it without a mount option =\n" - "tho so it just works,\n" - "> > >> does that sound good to you? =C2=A0Thanks,\n" - "> >=20\n" + "> > >> Oh good somebody uses this? \302\240We actually have a ->sequence thing we use for\n" + "> > >> this, the grand idea was to make it smarter about telling nfs when something\n" + "> > >> changed, but if you guys use i_version we could probably get rid of our in-core\n" + "> > >> sequence and use the normal inodes i_version and then just store it in our\n" + "> > >> sequence field on disk. \302\240I'll do it without a mount option tho so it just works,\n" + "> > >> does that sound good to you? \302\240Thanks,\n" + "> > \n" "> > Hello,\n" - "> >=20\n" + "> > \n" "> > Thank you for the answer...\n" "> > But can you a bit clarify...\n" - "> >=20\n" + "> > \n" "> > Looking to file_update_time() I see that it does:\n" - "> >=20\n" + "> > \n" "> > \tif (IS_I_VERSION(inode))\n" - "> > \t\tsync_it |=3D S_VERSION;\n" - "> >=20\n" + "> > \t\tsync_it |= S_VERSION;\n" + "> > \n" "> > Basically it should be (inode->i_sb->s_flags & MS_I_VERSION)\n" - "> >=20\n" + "> > \n" "> > use of i_version is controlled by iversion mount flag.\n" "> > for ext4 I see in parse_options():\n" - "> >=20\n" + "> > \n" "> > \t\tcase Opt_i_version:\n" "> > \t\t\tset_opt(sb, I_VERSION);\n" - "> > \t\t\tsb->s_flags |=3D MS_I_VERSION;\n" + "> > \t\t\tsb->s_flags |= MS_I_VERSION;\n" "> > \t\t\tbreak;\n" - "> >=20\n" - "> >=20\n" + "> > \n" + "> > \n" "> > But who sets MS_I_VERSION in s_flags on btrfs?\n" - "> >=20\n" - ">=20\n" - "> Nobody yet, I'm going to send a patch shortly that will support this.=\n" - " Thanks,\n" + "> > \n" + "> \n" + "> Nobody yet, I'm going to send a patch shortly that will support this. Thanks,\n" "\n" "Great. It would also be far preferable if it was just always on (at\n" "least by default) rather than requiring a mount option.\n" "\n" "--b.\n" "--\n" - "To unsubscribe from this list: send the line \"unsubscribe linux-btrfs\" =\n" - "in\n" + "To unsubscribe from this list: send the line \"unsubscribe linux-btrfs\" in\n" "the body of a message to majordomo@vger.kernel.org\n" More majordomo info at http://vger.kernel.org/majordomo-info.html -91495bd8cbcc9ac47d4ce1aa0ba6b3d89204d1402c19dc32373c9f85139928f1 +7d74531acb3ae192cb889c264e54e1f6c65f1c42ce7d25ec683ab1b3b28cefc3
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.