All of lore.kernel.org
 help / color / mirror / Atom feed
From: Oleg Nesterov <oleg@redhat.com>
To: David Howells <dhowells@redhat.com>,
	Linus Torvalds <torvalds@linux-foundation.org>
Cc: Andrew Morton <akpm@linux-foundation.org>,
	linux-kernel@vger.kernel.org, stable@vger.kernel.org
Subject: [PATCH 0/1] cred: copy_process() should clear child->replacement_session_keyring
Date: Mon, 9 Apr 2012 21:03:23 +0200	[thread overview]
Message-ID: <20120409190323.GA14712@redhat.com> (raw)

Hello.

Looks trivial, but I do not know how to test and I don't understand
this code. David, please review ;)

Note: initially this was 1/2. The usage of >replacement_session_keyring
is racy, although the problem is minor. I think that instead of fixing
a lot of key_replace_session_keyring's callers in arch/ we can add the
simple abstraction layer and kill ->replacement_session_keyring. I'll
try to send the patches tomorrow.

Btw. exit_creds() does validate_creds(cred) right before put_cred(cred),
without alter_cred_subscribers() in between this looks unneeded?

Oleg.


             reply	other threads:[~2012-04-09 19:03 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-04-09 19:03 Oleg Nesterov [this message]
2012-04-09 19:03 ` [PATCH 1/1] cred: copy_process() should clear child->replacement_session_keyring Oleg Nesterov
2012-04-10  1:05   ` [RFC PATCH 0/1] task_work_queue: add generic process-context callbacks Oleg Nesterov
2012-04-10  1:06     ` [RFC PATCH 1/1] " Oleg Nesterov
2012-04-11 10:47   ` [PATCH 1/1] cred: copy_process() should clear child->replacement_session_keyring David Howells

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120409190323.GA14712@redhat.com \
    --to=oleg@redhat.com \
    --cc=akpm@linux-foundation.org \
    --cc=dhowells@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=stable@vger.kernel.org \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.