From: Guenter Roeck <guenter.roeck@ericsson.com>
To: lm-sensors@vger.kernel.org
Subject: Re: [lm-sensors] [PATCH] hwmon: fam15h_power: fix bogus values with current BIOSes
Date: Tue, 10 Apr 2012 05:49:18 +0000 [thread overview]
Message-ID: <20120410054918.GA16621@ericsson.com> (raw)
In-Reply-To: <1333840079-13541-1-git-send-email-andre.przywara@amd.com>
On Tue, Apr 10, 2012 at 01:47:25AM -0400, Jean Delvare wrote:
> On Mon, 9 Apr 2012 23:55:56 +0200, Andre Przywara wrote:
> > On 04/09/2012 07:39 PM, Jean Delvare wrote:
> > > I am a little curious about the code BTW, as the value you write isn't
> > > the one you originally checked for, which means that reloading the
> > > driver would have to do it again...
> >
> > The whole code is about to fix a BIOS flaw. It needs to be done only
> > once after each reset, newer BIOSes will do this at boot time already.
> > So reloading the driver will not fix this again, because it is not
> > needed.
>
> Err, you're right, sorry. Probably I already had fever when I reviewed
> this patch but had not noticed yet. Sorry for the noise.
>
I almost sent a similar e-mail, so I must have had the same fever ;-).
Guenter
_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
next prev parent reply other threads:[~2012-04-10 5:49 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-07 23:07 [lm-sensors] [PATCH] hwmon: fam15h_power: fix bogus values with current BIOSes Andre Przywara
2012-04-09 2:26 ` Guenter Roeck
2012-04-09 17:14 ` Andre Przywara
2012-04-09 17:39 ` Jean Delvare
2012-04-09 21:55 ` Andre Przywara
2012-04-10 0:37 ` Phil Pokorny
2012-04-10 5:47 ` Jean Delvare
2012-04-10 5:49 ` Guenter Roeck [this message]
2012-04-10 13:49 ` Andre Przywara
2012-04-10 13:55 ` Jean Delvare
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120410054918.GA16621@ericsson.com \
--to=guenter.roeck@ericsson.com \
--cc=lm-sensors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.