All of lore.kernel.org
 help / color / mirror / Atom feed
From: Marek Vasut <marex@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] FAT: Properly align buffers to allow cache operations
Date: Tue, 10 Apr 2012 07:00:48 +0200	[thread overview]
Message-ID: <201204100700.48644.marex@denx.de> (raw)
In-Reply-To: <201204100036.07124.vapier@gentoo.org>

Dear Mike Frysinger,

> On Monday 09 April 2012 02:45:03 Marek Vasut wrote:
> > @@ -765,9 +767,6 @@
> > 
> > -__attribute__ ((__aligned__ (__alignof__ (dir_entry))))
> > -__u8 do_fat_read_block[MAX_CLUSTSIZE];
> > -
> > 
> > @@ -788,6 +787,7 @@ do_fat_read (const char *filename, void *buffer,
> > 
> >  	int rootdir_size = 0;
> >  	int j;
> > 
> > +	uint8_t do_fat_read_block[MAX_CLUSTSIZE] __attribute__((aligned(32)));
> 
> what's going on here exactly ?  the old code had the advantage of being in
> the bss and the linker taking care of the alignment.  this new code has an
> incorrectly hard-coded "32", and puts a 64KiB array onto the *stack*.

This will be probably fixed in Eric's patch

Best regards,
Marek Vasut

  reply	other threads:[~2012-04-10  5:00 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-04-09  6:45 [U-Boot] [PATCH] FAT: Properly align buffers to allow cache operations Marek Vasut
2012-04-09  8:20 ` Dirk Behme
2012-04-09  8:26   ` Marek Vasut
2012-04-09 10:28     ` Dirk Behme
2012-04-09 10:44       ` Marek Vasut
2012-04-09 13:35     ` Eric Nelson
2012-04-10  4:36 ` Mike Frysinger
2012-04-10  5:00   ` Marek Vasut [this message]
2012-04-10 15:07     ` Eric Nelson
2012-04-10 16:20       ` Dirk Behme
2012-04-10 20:34         ` Wolfgang Denk
2012-04-10 23:13           ` Eric Nelson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201204100700.48644.marex@denx.de \
    --to=marex@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.