Re: [oe-commits] Andrei Gherzan : gdbm: Activate -enable-libgdbm-compat and add symlinks to headers in include/ gdbm

[Martin Jansa <martin.jansa@gmail.com>]

[-- Attachment #1: Type: text/plain, Size: 2874 bytes --]

On Fri, Apr 06, 2012 at 12:17:38AM +0000, git@git.openembedded.org wrote:
> Module: openembedded-core.git
> Branch: master
> Commit: e4d2ee00419f675ba8b7fb5d75256762253d8b32
> URL:    http://git.openembedded.org/?p=openembedded-core.git&a=commit;h=e4d2ee00419f675ba8b7fb5d75256762253d8b32
> 
> Author: Andrei Gherzan <andrei@gherzan.ro>
> Date:   Fri Mar 23 17:56:29 2012 +0200
> 
> gdbm: Activate -enable-libgdbm-compat and add symlinks to headers in include/gdbm
> 
> ndbm.h is needed by python for dbm module. This is why -enable-libgdbm-compat was added
> to configure.
> The second change is because python is looking for the gdbm headers in include/gdbm.
> The easiest way to solve this issue is to add symlinks in include/gdbm.
> 
> [YOCTO #1937]
> 
> Signed-off-by: Andrei Gherzan <andrei@gherzan.ro>

This breaks every package in feed which depends on old package name
libgdbm4 (>= 1.10)

Because now there are 2 .so files in ${PN} and no LEAD_SONAME defined.

Are you going to 

1) send PR bumps to all packages which depends on libgdbm4
   (e.g. apr-util python pulseaudio perl gst-plugins-good and probably more)
2) define LEAD_SONAME and bump PR in gdbm recipe
3) move -compat libs to ${PN}-compat or some other package name, so that
   old libgdbm4 still exists (and maybe + 1) because some people could
   build those with gdbm as dependency now)

Cheers,


> 
> ---
> 
>  meta/recipes-support/gdbm/gdbm_1.10.bb |   13 ++++++++++++-
>  1 files changed, 12 insertions(+), 1 deletions(-)
> 
> diff --git a/meta/recipes-support/gdbm/gdbm_1.10.bb b/meta/recipes-support/gdbm/gdbm_1.10.bb
> index 9b2fde4..26b8009 100644
> --- a/meta/recipes-support/gdbm/gdbm_1.10.bb
> +++ b/meta/recipes-support/gdbm/gdbm_1.10.bb
> @@ -4,7 +4,7 @@ SECTION = "libs"
>  LICENSE = "GPLv3"
>  LIC_FILES_CHKSUM = "file://COPYING;md5=241da1b9fe42e642cbb2c24d5e0c4d24"
>  
> -PR = "r1" 
> +PR = "r2"
>  
>  SRC_URI = "${GNU_MIRROR}/gdbm/gdbm-${PV}.tar.gz"
>  
> @@ -13,4 +13,15 @@ SRC_URI[sha256sum] = "23f8134c5b94bbfb06d756a6b78f074fba6e6028cf2fe01341d40b26db
>  
>  inherit autotools gettext lib_package
>  
> +# Needed for dbm python module
> +EXTRA_OECONF = "-enable-libgdbm-compat"
> +
>  BBCLASSEXTEND = "native nativesdk"
> +
> +do_install_append () {
> +    # Create a symlink to ndbm.h and gdbm.h in include/gdbm to let other packages to find
> +    # these headers
> +    install -d ${D}${includedir}/gdbm
> +    ln -sf ../ndbm.h ${D}/${includedir}/gdbm/ndbm.h
> +    ln -sf ../gdbm.h ${D}/${includedir}/gdbm/gdbm.h
> +}
> 
> 
> _______________________________________________
> Openembedded-commits mailing list
> Openembedded-commits@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-commits

-- 
Martin 'JaMa' Jansa     jabber: Martin.Jansa@gmail.com

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 205 bytes --]