From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH v2] drm/i915: use semaphores for the display plane Date: Tue, 10 Apr 2012 12:04:11 +0200 Message-ID: <20120410100411.GF4115@phenom.ffwll.local> References: <1333662456-10976-1-git-send-email-ben@bwidawsk.net> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail-wg0-f43.google.com (mail-wg0-f43.google.com [74.125.82.43]) by gabe.freedesktop.org (Postfix) with ESMTP id 1A7639EA09 for ; Tue, 10 Apr 2012 03:03:19 -0700 (PDT) Received: by wgbdr12 with SMTP id dr12so3924942wgb.12 for ; Tue, 10 Apr 2012 03:03:19 -0700 (PDT) Content-Disposition: inline In-Reply-To: <1333662456-10976-1-git-send-email-ben@bwidawsk.net> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Ben Widawsky Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On Thu, Apr 05, 2012 at 02:47:36PM -0700, Ben Widawsky wrote: > In theory this will have performance and power improvements. Performance > because we don't need to stall when the scanout BO is busy, and power > because we don't have to stall when the BO is busy (and the ring can > even go to sleep if the HW supports it). > > v2: > squash 2 patches into 1 (me) > un-inline the enable_semaphores function (Daniel) > remove comment about SNB hangs from i915_gem_object_sync (Chris) > rename intel_enable_semaphores to i915_semaphore_is_enabled (me) > removed page flip comment; "no why" (Chris) > > To address other comments from Daniel (irc): > update the comment to say 'vt-d is crap, don't enable semaphores' > - I think you misinterpreted Chris' comment, it already exists. > checking out whether we can pageflip on the render ring on ivb (didn't > work on early silicon) > - We don't want to enable workarounds for early silicon unless we have > to. > - I can't find any references in the docs about this. > optionally use it if the fb is already busy on the render ring > - This should be how the code already worked, unless I am > misunderstanding your meaning. > > CC: Chris Wilson > Signed-off-by: Ben Widawsky Queued for -next (with Chris' irc r-b added), thanks for the patch. -Daniel -- Daniel Vetter Mail: daniel@ffwll.ch Mobile: +41 (0)79 365 57 48