diff for duplicates of <20120410105725.GA5589@mwanda> diff --git a/a/1.txt b/N1/1.txt index b568426..3c5f2c4 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -1,9 +1,7 @@ On Tue, Apr 10, 2012 at 11:58:26AM +0200, Felix Fietkau wrote: > > if ((aniState->noiseFloor >= aniState->rssiThrHigh) && -> > - (!aniState->ofdmWeakSigDetectOff != -> > + (aniState->ofdmWeakSigDetectOff != -> Looking at other Atheros code, I think this patch is wrong, it should -> be: aniState->ofdmWeakSigDetectOff == entry_ofdm->ofdm_weak_signal_on +> > - (!aniState->ofdmWeakSigDetectOff !> > + (aniState->ofdmWeakSigDetectOff !> Looking at other Atheros code, I think this patch is wrong, it should +> be: aniState->ofdmWeakSigDetectOff = entry_ofdm->ofdm_weak_signal_on > > While a bit confusing, the behavior of the original code was correct, > aniState->ofdmWeakSigDetectOff is used as a boolean. @@ -16,7 +14,7 @@ Yep. It's bad to name variables xxx_off because it leads triple negatives like we see here. I guess that "if (!off != on) { ..." might be more readable than -"if (off == on) { ...". There are a couple ways to silence this +"if (off = on) { ...". There are a couple ways to silence this warning in Smatch. The first way would be to add parenthesis like, diff --git a/a/content_digest b/N1/content_digest index 85ed81f..50e29ef 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -1,17 +1,24 @@ "ref\020120410090445.GB26832@elgon.mountain\0" "ref\04F840442.5060706@openwrt.org\0" "From\0Dan Carpenter <dan.carpenter@oracle.com>\0" - "Subject\0[ath9k-devel] [RFC] ath9k_hw: precedence bug in ath9k_hw_set_ofdm_nil()\0" - "Date\0Tue, 10 Apr 2012 13:57:25 +0300\0" - "To\0ath9k-devel@lists.ath9k.org\0" + "Subject\0Re: [ath9k-devel] [RFC] ath9k_hw: precedence bug in ath9k_hw_set_ofdm_nil()\0" + "Date\0Tue, 10 Apr 2012 10:57:25 +0000\0" + "To\0Felix Fietkau <nbd@openwrt.org>\0" + "Cc\0Luis R. Rodriguez <mcgrof@qca.qualcomm.com>" + Rajkumar Manoharan <rmanohar@qca.qualcomm.com> + Vasanthakumar Thiagarajan <vthiagar@qca.qualcomm.com> + ath9k-devel@venema.h4ckr.net + kernel-janitors@vger.kernel.org + Jouni Malinen <jouni@qca.qualcomm.com> + linux-wireless@vger.kernel.org + John W. Linville <linville@tuxdriver.com> + " Senthil Balasubramanian <senthilb@qca.qualcomm.com>\0" "\00:1\0" "b\0" "On Tue, Apr 10, 2012 at 11:58:26AM +0200, Felix Fietkau wrote:\n" "> > \tif ((aniState->noiseFloor >= aniState->rssiThrHigh) &&\n" - "> > -\t (!aniState->ofdmWeakSigDetectOff !=\n" - "> > +\t (aniState->ofdmWeakSigDetectOff !=\n" - "> Looking at other Atheros code, I think this patch is wrong, it should\n" - "> be: aniState->ofdmWeakSigDetectOff == entry_ofdm->ofdm_weak_signal_on\n" + "> > -\t (!aniState->ofdmWeakSigDetectOff !> > +\t (aniState->ofdmWeakSigDetectOff !> Looking at other Atheros code, I think this patch is wrong, it should\n" + "> be: aniState->ofdmWeakSigDetectOff = entry_ofdm->ofdm_weak_signal_on\n" "> \n" "> While a bit confusing, the behavior of the original code was correct,\n" "> aniState->ofdmWeakSigDetectOff is used as a boolean.\n" @@ -24,7 +31,7 @@ "negatives like we see here.\n" "\n" "I guess that \"if (!off != on) { ...\" might be more readable than\n" - "\"if (off == on) { ...\". There are a couple ways to silence this\n" + "\"if (off = on) { ...\". There are a couple ways to silence this\n" "warning in Smatch.\n" "\n" "The first way would be to add parenthesis like,\n" @@ -40,4 +47,4 @@ "regards,\n" dan carpenter -bc2ae07039c46b347d57cf1a4a4a6e011f886af5a206702237770621708dc6fe +444990427ef708023ee1bb0caf8332c4ebec44656780c1d76a26ce874fd30beb
diff --git a/a/content_digest b/N2/content_digest index 85ed81f..2047aeb 100644 --- a/a/content_digest +++ b/N2/content_digest @@ -1,9 +1,18 @@ "ref\020120410090445.GB26832@elgon.mountain\0" "ref\04F840442.5060706@openwrt.org\0" "From\0Dan Carpenter <dan.carpenter@oracle.com>\0" - "Subject\0[ath9k-devel] [RFC] ath9k_hw: precedence bug in ath9k_hw_set_ofdm_nil()\0" + "Subject\0Re: [ath9k-devel] [RFC] ath9k_hw: precedence bug in ath9k_hw_set_ofdm_nil()\0" "Date\0Tue, 10 Apr 2012 13:57:25 +0300\0" - "To\0ath9k-devel@lists.ath9k.org\0" + "To\0Felix Fietkau <nbd@openwrt.org>\0" + "Cc\0Luis R. Rodriguez <mcgrof@qca.qualcomm.com>" + Rajkumar Manoharan <rmanohar@qca.qualcomm.com> + Vasanthakumar Thiagarajan <vthiagar@qca.qualcomm.com> + ath9k-devel@venema.h4ckr.net + kernel-janitors@vger.kernel.org + Jouni Malinen <jouni@qca.qualcomm.com> + linux-wireless@vger.kernel.org + John W. Linville <linville@tuxdriver.com> + " Senthil Balasubramanian <senthilb@qca.qualcomm.com>\0" "\00:1\0" "b\0" "On Tue, Apr 10, 2012 at 11:58:26AM +0200, Felix Fietkau wrote:\n" @@ -40,4 +49,4 @@ "regards,\n" dan carpenter -bc2ae07039c46b347d57cf1a4a4a6e011f886af5a206702237770621708dc6fe +606a1961a262adf23b6d6e8bf241866c26f1cc0b41c956c33dcff511ed773919
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.