From mboxrd@z Thu Jan 1 00:00:00 1970 From: Arnd Bergmann Subject: Re: [PATCHv8 04/10] ARM: dma-mapping: remove offset parameter to prepare for generic dma_ops Date: Tue, 10 Apr 2012 11:43:27 +0000 Message-ID: <201204101143.27915.arnd@arndb.de> References: <1334055852-19500-1-git-send-email-m.szyprowski@samsung.com> <1334055852-19500-5-git-send-email-m.szyprowski@samsung.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1334055852-19500-5-git-send-email-m.szyprowski@samsung.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: linux-arm-kernel-bounces@lists.infradead.org Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: Marek Szyprowski Cc: linux-arch@vger.kernel.org, Russell King - ARM Linux , Konrad Rzeszutek Wilk , Benjamin Herrenschmidt , Joerg Roedel , Kyungmin Park , Subash Patel , linaro-mm-sig@lists.linaro.org, linux-mm@kvack.org, iommu@lists.linux-foundation.org, Andrzej Pietrasiewicz , KyongHo Cho , Chunsang Jeong , linux-arm-kernel@lists.infradead.org, Hiroshi Doyu List-Id: linux-arch.vger.kernel.org On Tuesday 10 April 2012, Marek Szyprowski wrote: > This patch removes the need for offset parameter in dma bounce > functions. This is required to let dma-mapping framework on ARM > architecture use common, generic dma-mapping helpers. > > Signed-off-by: Marek Szyprowski > Acked-by: Kyungmin Park This one worries me a little. I always thought that the range sync functions were specifically needed for the dmabounce code. At the very least, I would expect the changeset comment to have an explanation of why this was initially done this way and why it's now safe to do do it otherwise. Arnd From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from moutng.kundenserver.de ([212.227.126.171]:55425 "EHLO moutng.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751625Ab2DJLoN (ORCPT ); Tue, 10 Apr 2012 07:44:13 -0400 From: Arnd Bergmann Subject: Re: [PATCHv8 04/10] ARM: dma-mapping: remove offset parameter to prepare for generic dma_ops Date: Tue, 10 Apr 2012 11:43:27 +0000 References: <1334055852-19500-1-git-send-email-m.szyprowski@samsung.com> <1334055852-19500-5-git-send-email-m.szyprowski@samsung.com> In-Reply-To: <1334055852-19500-5-git-send-email-m.szyprowski@samsung.com> MIME-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-15" Content-Transfer-Encoding: 7bit Message-ID: <201204101143.27915.arnd@arndb.de> Sender: linux-arch-owner@vger.kernel.org List-ID: To: Marek Szyprowski Cc: linux-arm-kernel@lists.infradead.org, linaro-mm-sig@lists.linaro.org, linux-mm@kvack.org, linux-arch@vger.kernel.org, iommu@lists.linux-foundation.org, Kyungmin Park , Joerg Roedel , Russell King - ARM Linux , Chunsang Jeong , Krishna Reddy , KyongHo Cho , Andrzej Pietrasiewicz , Benjamin Herrenschmidt , Konrad Rzeszutek Wilk , Hiroshi Doyu , Subash Patel Message-ID: <20120410114327.fyt0cNP38fSvebRfQBUrzWp6qI1RpUAkwUz17eICb0k@z> On Tuesday 10 April 2012, Marek Szyprowski wrote: > This patch removes the need for offset parameter in dma bounce > functions. This is required to let dma-mapping framework on ARM > architecture use common, generic dma-mapping helpers. > > Signed-off-by: Marek Szyprowski > Acked-by: Kyungmin Park This one worries me a little. I always thought that the range sync functions were specifically needed for the dmabounce code. At the very least, I would expect the changeset comment to have an explanation of why this was initially done this way and why it's now safe to do do it otherwise. Arnd From mboxrd@z Thu Jan 1 00:00:00 1970 From: arnd@arndb.de (Arnd Bergmann) Date: Tue, 10 Apr 2012 11:43:27 +0000 Subject: [PATCHv8 04/10] ARM: dma-mapping: remove offset parameter to prepare for generic dma_ops In-Reply-To: <1334055852-19500-5-git-send-email-m.szyprowski@samsung.com> References: <1334055852-19500-1-git-send-email-m.szyprowski@samsung.com> <1334055852-19500-5-git-send-email-m.szyprowski@samsung.com> Message-ID: <201204101143.27915.arnd@arndb.de> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Tuesday 10 April 2012, Marek Szyprowski wrote: > This patch removes the need for offset parameter in dma bounce > functions. This is required to let dma-mapping framework on ARM > architecture use common, generic dma-mapping helpers. > > Signed-off-by: Marek Szyprowski > Acked-by: Kyungmin Park This one worries me a little. I always thought that the range sync functions were specifically needed for the dmabounce code. At the very least, I would expect the changeset comment to have an explanation of why this was initially done this way and why it's now safe to do do it otherwise. Arnd From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from psmtp.com (na3sys010amx149.postini.com [74.125.245.149]) by kanga.kvack.org (Postfix) with SMTP id 28C6C6B00F0 for ; Tue, 10 Apr 2012 07:44:19 -0400 (EDT) From: Arnd Bergmann Subject: Re: [PATCHv8 04/10] ARM: dma-mapping: remove offset parameter to prepare for generic dma_ops Date: Tue, 10 Apr 2012 11:43:27 +0000 References: <1334055852-19500-1-git-send-email-m.szyprowski@samsung.com> <1334055852-19500-5-git-send-email-m.szyprowski@samsung.com> In-Reply-To: <1334055852-19500-5-git-send-email-m.szyprowski@samsung.com> MIME-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-15" Content-Transfer-Encoding: 7bit Message-Id: <201204101143.27915.arnd@arndb.de> Sender: owner-linux-mm@kvack.org List-ID: To: Marek Szyprowski Cc: linux-arm-kernel@lists.infradead.org, linaro-mm-sig@lists.linaro.org, linux-mm@kvack.org, linux-arch@vger.kernel.org, iommu@lists.linux-foundation.org, Kyungmin Park , Joerg Roedel , Russell King - ARM Linux , Chunsang Jeong , Krishna Reddy , KyongHo Cho , Andrzej Pietrasiewicz , Benjamin Herrenschmidt , Konrad Rzeszutek Wilk , Hiroshi Doyu , Subash Patel On Tuesday 10 April 2012, Marek Szyprowski wrote: > This patch removes the need for offset parameter in dma bounce > functions. This is required to let dma-mapping framework on ARM > architecture use common, generic dma-mapping helpers. > > Signed-off-by: Marek Szyprowski > Acked-by: Kyungmin Park This one worries me a little. I always thought that the range sync functions were specifically needed for the dmabounce code. At the very least, I would expect the changeset comment to have an explanation of why this was initially done this way and why it's now safe to do do it otherwise. Arnd -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/ Don't email: email@kvack.org