From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jesse Barnes Subject: Re: [PATCH 2/3] drm/i915: check PPS regs for sanity when using eDP Date: Tue, 10 Apr 2012 11:59:10 -0700 Message-ID: <20120410115910.56d75feb@jbarnes-desktop> References: <1334084285-4770-1-git-send-email-jbarnes@virtuousgeek.org> <1334084285-4770-2-git-send-email-jbarnes@virtuousgeek.org> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============0975844710==" Return-path: Received: from oproxy6-pub.bluehost.com (oproxy6-pub.bluehost.com [67.222.54.6]) by gabe.freedesktop.org (Postfix) with SMTP id CA6659F598 for ; Tue, 10 Apr 2012 11:59:13 -0700 (PDT) Received: from c-67-161-37-189.hsd1.ca.comcast.net ([67.161.37.189] helo=jbarnes-desktop) by box514.bluehost.com with esmtpsa (TLSv1:AES128-SHA:128) (Exim 4.76) (envelope-from ) id 1SHgHY-00027G-U9 for intel-gfx@lists.freedesktop.org; Tue, 10 Apr 2012 12:59:13 -0600 In-Reply-To: <1334084285-4770-2-git-send-email-jbarnes@virtuousgeek.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org --===============0975844710== Content-Type: multipart/signed; micalg=PGP-SHA1; boundary="Sig_/bf5HlnpHbb90L..+ImbVSAp"; protocol="application/pgp-signature" --Sig_/bf5HlnpHbb90L..+ImbVSAp Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable On Tue, 10 Apr 2012 11:58:04 -0700 Jesse Barnes wrote: > If these regs don't have valid values, the panel won't come up, and may > even cause a system hang. So do a basic sanity check when an eDP panel > is detected. >=20 > Signed-off-by: Jesse Barnes > --- > drivers/gpu/drm/i915/intel_dp.c | 7 +++++++ > 1 files changed, 7 insertions(+), 0 deletions(-) >=20 > diff --git a/drivers/gpu/drm/i915/intel_dp.c b/drivers/gpu/drm/i915/intel= _dp.c > index 110552f..6346b29 100644 > --- a/drivers/gpu/drm/i915/intel_dp.c > +++ b/drivers/gpu/drm/i915/intel_dp.c > @@ -2462,6 +2462,13 @@ intel_dp_init(struct drm_device *dev, int output_r= eg) > pp_off =3D I915_READ(PCH_PP_OFF_DELAYS); > pp_div =3D I915_READ(PCH_PP_DIVISOR); > =20 > + if (!pp_on || !pp_off || !pp_div) { > + DRM_INFO("bad panel power sequencing delays, disabling panel\n"); > + intel_dp_encoder_destroy(&intel_dp->base.base); > + intel_dp_destroy(&intel_connector->base); > + return; > + } > + > /* Pull timing values out of registers */ > cur.t1_t3 =3D (pp_on & PANEL_POWER_UP_DELAY_MASK) >> > PANEL_POWER_UP_DELAY_SHIFT; Forgot to add, this one references https://bugs.freedesktop.org/show_bug.cgi?id=3D44305 so if it looks ok, please add that to the commit message. Thanks, --=20 Jesse Barnes, Intel Open Source Technology Center --Sig_/bf5HlnpHbb90L..+ImbVSAp Content-Type: application/pgp-signature; name=signature.asc Content-Disposition: attachment; filename=signature.asc -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.11 (GNU/Linux) iQIcBAEBAgAGBQJPhIL+AAoJEIEoDkX4Qk9he+QP/0iSQjLLYNChNCbfP3O0tmAT BZ+DwI95SfrZJOC/LM3toO3SQd8UmXWKfCL/arK+dnATkwlBuT3SXnewdJJ87t4S gP0ewoLJLDZ3iyoSXWgpgjZaYpDRndz6y/Wf87gQHSELpc4nfhv3zNpqvEgm4J5K q4+BGLnJKNhOusuhewBz9VXxNpQXS4FC0/zrGQba4K4hDwZ35aHdoPX8A7AKuKRu 7LCNXo6GmG8Xn3C5pT0h72gag0+lIO2loIXV9J4rLTa3qCBSdsg6G5sYAacLUMCm p100BCmC1E6fYrMh7yTlBRO0ng/dEftE3TP9zj0L7kiXj4ex1ynCvuilXzNgHyKF AkAbOsvWR18A3t0x627VLFXT3KjHVF2Wjfp5KS1XL1D4ALDcWJ7U5UqJ2zwF3ZSk eIDBf9ve1Hxm43l0jUB38fMNk7S/v2rVGf3cNmqc/zy0mx1oPLkBJS3VT/kwz3/U vAQvIm4Ve36qX71ZGkhjG8MllrJrFBpk/E/oiqkYfu97jkzSJB1f9yELNq4hbo9K ebXpP6QqOX3er7AxYhRENbDmxN99OQG2HedS/slCRH6qQLpbdyYdG+tN0X5Zr0nn N+ienvjg8Ar7xHB67BkV9C3zwmAxmWY9aRkyzfBu8L1+II/B6oAJ7vGUNhlh9goH 8tEngTF5BEdD2gNyyoth =gtO6 -----END PGP SIGNATURE----- --Sig_/bf5HlnpHbb90L..+ImbVSAp-- --===============0975844710== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/intel-gfx --===============0975844710==--