From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1759213Ab2DJTTw (ORCPT <rfc822;w@1wt.eu>);
	Tue, 10 Apr 2012 15:19:52 -0400
Received: from mail.linuxfoundation.org ([140.211.169.12]:44726 "EHLO
	mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1752034Ab2DJTTu (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Tue, 10 Apr 2012 15:19:50 -0400
Date: Tue, 10 Apr 2012 12:19:49 -0700
From: Andrew Morton <akpm@linux-foundation.org>
To: Andi Kleen <ak@linux.intel.com>
Cc: Jason Wessel <jason.wessel@windriver.com>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH][REGRESSION] panic: fix stack dump print on direct call
 to panic()
Message-Id: <20120410121949.71145057.akpm@linux-foundation.org>
In-Reply-To: <4F832BC8.4090907@linux.intel.com>
References: <1333992030-21181-1-git-send-email-jason.wessel@windriver.com>
	<4F832BC8.4090907@linux.intel.com>
X-Mailer: Sylpheed 3.0.2 (GTK+ 2.20.1; x86_64-pc-linux-gnu)
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon, 09 Apr 2012 11:34:48 -0700
Andi Kleen <ak@linux.intel.com> wrote:

> > The proper way to resolve the problem that original commit tried to
> > solve is to avoid printing a stack dump from panic() when the either
> > of the following conditions is true:
> >
> >    1) TAINT_DIE has been set (this is done by oops_end())
> >       This indicates and oops has already been printed.
> >    2) oops_in_progress>  1
> >       This guards against the rare case where panic() is invoked
> >       a second time, or in between oops_begin() and oops_end()
> 
> Oops. I guess can just revert it for now. Thanks for catching, Jason.

You're suggesting a revert of 6e6f0a1f0, but Jason is suggesting that
it be repaired.  Confused.