From: Jonathan Nieder <jrnieder@gmail.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: Ross Lagerwall <rosslagerwall@gmail.com>, git@vger.kernel.org
Subject: Re: [PATCH] rev-parse --show-prefix: add in trailing newline
Date: Tue, 10 Apr 2012 09:04:21 -0500 [thread overview]
Message-ID: <20120410140421.GC2444@burratino> (raw)
In-Reply-To: <7v1unwwwov.fsf@alter.siamese.dyndns.org>
Junio C Hamano wrote:
> But it will break existing scripts if they expect the following to work:
>
> file="$(git rev-parse --show-prefix)/$1"
> cd_to_toplevel
> test -f "$file"
Huh? I tried this:
$ foo="$(printf '\n')/bar"
$ printf '%s\n' "$foo"
/bar
If that didn't work, it would mean that "git rev-parse --show-prefix"
would never work when the prefix is nonempty, because it is followed
by a newline.
next prev parent reply other threads:[~2012-04-10 14:04 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-09 13:27 [PATCH] rev-parse --show-prefix: add in trailing newline Ross Lagerwall
2012-04-09 19:07 ` Junio C Hamano
2012-04-10 5:30 ` Ross Lagerwall
2012-04-10 14:04 ` Jonathan Nieder [this message]
2012-04-10 14:41 ` Andreas Schwab
2012-04-10 16:14 ` Junio C Hamano
2012-04-10 17:36 ` Jonathan Nieder
2012-04-10 17:56 ` Junio C Hamano
2012-04-10 22:51 ` Nguyen Thai Ngoc Duy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120410140421.GC2444@burratino \
--to=jrnieder@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=rosslagerwall@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.