All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Andrew Miller <amiller@amilx.com>
Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 5/5] Staging: rtl8187se: r8185b_init.c: Fix comment blocks
Date: Tue, 10 Apr 2012 09:24:03 -0700	[thread overview]
Message-ID: <20120410162403.GA5753@kroah.com> (raw)
In-Reply-To: <1331938060-10207-6-git-send-email-amiller@amilx.com>

On Fri, Mar 16, 2012 at 06:47:40PM -0400, Andrew Miller wrote:
> Reformated comment blocks to meet Coding Style

That's good, but note that you also added more coding style violations
when you wrote this patch.

Please ALWAYS run your patches through scripts/checkpatch.pl to keep
this from happening.

I've taken this one for now, but now you have another follow-on patch
that you owe me to fix this one :)

thanks,

gregk -h

      reply	other threads:[~2012-04-10 16:24 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-03-16 22:47 [PATCH 0/5] Staging: rtl8187se: r8185b_init.c: Fix Coding Style issues Andrew Miller
2012-03-16 22:47 ` [PATCH 1/5] Staging: rtl8187se: r8185b_init.c: Fixed spacing Andrew Miller
2012-03-16 22:47 ` [PATCH 2/5] Staging: rtl8187se: r8185b_init.c: Fix function declarations Andrew Miller
2012-03-16 22:47 ` [PATCH 3/5] Staging: rtl8187se: r8185b_init.c: Fix some spacing issues Andrew Miller
2012-03-16 22:47 ` [PATCH 4/5] Staging: rtl8187se: r8185b_init.c: Removed old comments Andrew Miller
2012-03-16 22:47 ` [PATCH 5/5] Staging: rtl8187se: r8185b_init.c: Fix comment blocks Andrew Miller
2012-04-10 16:24   ` Greg KH [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120410162403.GA5753@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=amiller@amilx.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.