From: Ted Ts'o <tytso@mit.edu>
To: Andreas Dilger <adilger@whamcloud.com>
Cc: linux-ext4@vger.kernel.org
Subject: Re: [PATCH] tests: add test for symlink extent
Date: Tue, 10 Apr 2012 23:45:47 -0400 [thread overview]
Message-ID: <20120411034547.GD12044@thunk.org> (raw)
In-Reply-To: <1334093657-32559-1-git-send-email-adilger@whamcloud.com>
On Tue, Apr 10, 2012 at 03:34:17PM -0600, Andreas Dilger wrote:
> Long symlinks with the EXT4_EXTENTS_FL set may have been created at
> one time due to the EXTENTS_FL being inherited from the parent dir.
> While the original cause of such symlinks has been fixed in the
> upstream kernel commit 2dc6b0d48ca0599837df21b14bb8393d0804af57,
> such symlinks may still exist in the wild.
Huh? We're still creating long symlinks with extents, and I'm not
sure why this would be a problem. I don't mind a test for it, but it
seems strange that (a) you think e2fsprogs wouldn't be able to deal
with it, and (b) that we aren't doing it any more. I just tested with
a 3.3 kernel with the patches from the ext4's 3.4 merge window, and it
created a symlink with an extent.
See line 872 of fs/ext4/ialloc.c:
if (EXT4_HAS_INCOMPAT_FEATURE(sb, EXT4_FEATURE_INCOMPAT_EXTENTS)) {
/* set extent flag only for directory, file and normal symlink*/
if (S_ISDIR(mode) || S_ISREG(mode) || S_ISLNK(mode)) {
ext4_set_inode_flag(inode, EXT4_INODE_EXTENTS);
ext4_ext_tree_init(handle, inode);
}
}
- Ted
next prev parent reply other threads:[~2012-04-11 3:45 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-10 21:34 [PATCH] tests: add test for symlink extent Andreas Dilger
2012-04-11 3:45 ` Ted Ts'o [this message]
2012-04-11 5:06 ` Andreas Dilger
2012-04-11 18:07 ` Ted Ts'o
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120411034547.GD12044@thunk.org \
--to=tytso@mit.edu \
--cc=adilger@whamcloud.com \
--cc=linux-ext4@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.