From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH] drm/i915: simplify ppgtt setup Date: Wed, 11 Apr 2012 11:55:46 +0200 Message-ID: <20120411095546.GC4296@phenom.ffwll.local> References: <1334070641_347601@CP5-2952> <1334071757-16236-1-git-send-email-daniel.vetter@ffwll.ch> <1334072020_347922@CP5-2952> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail-ee0-f49.google.com (mail-ee0-f49.google.com [74.125.83.49]) by gabe.freedesktop.org (Postfix) with ESMTP id EB0FE9EB3D for ; Wed, 11 Apr 2012 02:54:54 -0700 (PDT) Received: by eekb45 with SMTP id b45so168136eek.36 for ; Wed, 11 Apr 2012 02:54:54 -0700 (PDT) Content-Disposition: inline In-Reply-To: <1334072020_347922@CP5-2952> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Chris Wilson Cc: daniel.vetter@ffwll.ch, Intel Graphics Development List-Id: intel-gfx@lists.freedesktop.org On Tue, Apr 10, 2012 at 04:33:38PM +0100, Chris Wilson wrote: > On Tue, 10 Apr 2012 17:29:17 +0200, daniel.vetter@ffwll.ch wrote: > > From: Daniel Vetter > > > > We don't need the pt_addr for the !dmar case, so drop the else and > > move the if (dmar) condition out of the loop. > > > > v2: Fixup whitespace damage noticed by Chris Wilson. > > > > v3: Collapse the two identical if blocks. Chris Wilson makes me look > > like a moron right now ... > > > > Noticed-by: Konstantin Belousov > > Signed-Off-by: Daniel Vetter > > Reviewed-by: Chris Wilson Queued for -next, thanks for the review. -Daniel -- Daniel Vetter Mail: daniel@ffwll.ch Mobile: +41 (0)79 365 57 48