All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] Add lcdproc config options, for driver selection
Date: Wed, 11 Apr 2012 13:40:35 +0200	[thread overview]
Message-ID: <20120411134035.28ead13f@skate> (raw)
In-Reply-To: <1334143890-11880-1-git-send-email-spdawson@gmail.com>

Hello,

Le Wed, 11 Apr 2012 12:31:30 +0100,
spdawson at gmail.com a ?crit :

> Add a configuration menu item to specify a list of lcdproc drivers to
> be built. The list defaults to 'all'.

Ok, I told you to wait for others comments on whether we should have
the full list (as you did initially) or this solution. I didn't want to
waste your time on this. Some comments below, though.

> +config BR2_PACKAGE_LCDPROC_DRIVERS
> +	string "List of drivers to build"
> +	default "all"
> +	help
> +	  Specify a comma-separated list of lcdproc drivers to be built
> +	depends on BR2_PACKAGE_LCDPROC

The depends on should be before the help text. It's not mandatory by
the kconfig syntax, but that's the way we use kconfig everywhere in
Buildroot.

Thomas
-- 
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com

  reply	other threads:[~2012-04-11 11:40 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-04-11 11:31 [Buildroot] [PATCH] Add lcdproc config options, for driver selection spdawson at gmail.com
2012-04-11 11:40 ` Thomas Petazzoni [this message]
  -- strict thread matches above, loose matches on Subject: below --
2012-04-11 12:12 spdawson at gmail.com
2012-05-01 20:33 ` Peter Korsgaard
2012-04-11 11:07 spdawson at gmail.com
2012-04-11 10:02 spdawson at gmail.com
2012-04-11  9:53 ` Jean-Christophe PLAGNIOL-VILLARD
2012-04-11 10:17 ` Thomas Petazzoni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120411134035.28ead13f@skate \
    --to=thomas.petazzoni@free-electrons.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.