From: Jakub Narebski <jnareb@gmail.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org, Sebastian Pipping <sebastian@pipping.org>
Subject: Re: [PATCH (bugfix)] gitweb: Fix unintended "--no-merges" for regular Atom feed
Date: Wed, 11 Apr 2012 17:39:06 +0200 [thread overview]
Message-ID: <201204111739.07765.jnareb@gmail.com> (raw)
In-Reply-To: <201204042058.32549.jnareb@gmail.com>
On Wed, 4 April 2012, Jakub Narebski wrote:
> Junio C Hamano wrote:
> > Jakub Narebski <jnareb@gmail.com> writes:
> >
> > > Junio, the bug is very minor, so I don't know if it is worth fixing
> > > for 1.7.10.
> >
> > Does this exist in 1.7.9.x maintenance track? If it is an old bug, I do
> > not think it should go to 1.7.10 proper (perhaps 1.7.10.1) this late, and
> > if it is a bug in a new feature added for 1.7.10, we may want to fix it
> > before the final, as the impact of the patch seems very minor.
>
> It is an old bug, from 05bb5a2 (gitweb: Include links to feeds in HTML
> header only for '200 OK' response, 2010-12-18) which refactored feed link
> generation into print_feed_meta(). It is in gitweb since v1.7.4 I think.
>
> So 1.7.10.1 it is...
Ping!
I don't see this trivial fix (admittedly for obscure bug) in "What's
cooking", and it is not present in 'master'.
> > > gitweb/gitweb.perl | 1 +
> > > 1 files changed, 1 insertions(+), 0 deletions(-)
--
Jakub Narebski
Poland
next prev parent reply other threads:[~2012-04-11 15:39 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-02 16:44 [PATCH] Gitweb: Fix unintended "--no-merges" for regular Atom feed Sebastian Pipping
2012-04-04 12:25 ` [PATCH (bugfix)] gitweb: " Jakub Narebski
2012-04-04 17:47 ` Junio C Hamano
2012-04-04 18:58 ` Jakub Narebski
2012-04-11 15:39 ` Jakub Narebski [this message]
2012-04-11 16:48 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201204111739.07765.jnareb@gmail.com \
--to=jnareb@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=sebastian@pipping.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.