From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mail-pz0-f43.google.com ([209.85.210.43]) by merlin.infradead.org with esmtps (Exim 4.76 #1 (Red Hat Linux)) id 1SIT0l-0006eN-GE for kexec@lists.infradead.org; Thu, 12 Apr 2012 23:01:08 +0000 Received: by dadn15 with SMTP id n15so3765724dad.16 for ; Thu, 12 Apr 2012 16:01:03 -0700 (PDT) Date: Thu, 12 Apr 2012 16:00:58 -0700 From: Greg KH Subject: Re: [PATCH 3/4] ksysfs: export VMCSINFO via sysfs Message-ID: <20120412230058.GA23292@kroah.com> References: <4F84E0DF.8040206@cn.fujitsu.com> <4F84E50E.2090008@cn.fujitsu.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <4F84E50E.2090008@cn.fujitsu.com> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: kexec-bounces@lists.infradead.org Errors-To: kexec-bounces+dwmw2=infradead.org@lists.infradead.org To: zhangyanfei Cc: dzickus@redhat.com, luto@mit.edu, gregkh@suse.de, kvm@vger.kernel.org, joerg.roedel@amd.com, mtosatti@redhat.com, kexec@lists.infradead.org, linux-kernel@vger.kernel.org, paul.gortmaker@windriver.com, ludwig.nussel@suse.de, avi@redhat.com, ebiederm@xmission.com On Wed, Apr 11, 2012 at 09:57:34AM +0800, zhangyanfei wrote: > This patch creates sysfs file to export where VMCSINFO is allocated, > as below: > $ cat /sys/kernel/vmcsinfo > 1cb88a0 2000 > number on the left-hand side is the physical address of VMCSINFO, > while the one on the right-hand side is the max size of VMCSINFO. Ick, why do you have 2 values in one sysfs file, that's not nice, or good. What's wrong with 2 different files? Also, any new sysfs file you add needs to also have a Documentation/ABI entry added as well. But we can't accept this as-is, sorry, please split it up into 2 files. greg k-h _______________________________________________ kexec mailing list kexec@lists.infradead.org http://lists.infradead.org/mailman/listinfo/kexec From mboxrd@z Thu Jan 1 00:00:00 1970 From: Greg KH Subject: Re: [PATCH 3/4] ksysfs: export VMCSINFO via sysfs Date: Thu, 12 Apr 2012 16:00:58 -0700 Message-ID: <20120412230058.GA23292@kroah.com> References: <4F84E0DF.8040206@cn.fujitsu.com> <4F84E50E.2090008@cn.fujitsu.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: dzickus-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org, luto-3s7WtUTddSA@public.gmane.org, gregkh-l3A5Bk7waGM@public.gmane.org, kvm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, joerg.roedel-5C7GfCeVMHo@public.gmane.org, mtosatti-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org, kexec-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, paul.gortmaker-CWA4WttNNZF54TAoqtyWWQ@public.gmane.org, ludwig.nussel-l3A5Bk7waGM@public.gmane.org, avi-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org, ebiederm-aS9lmoZGLiVWk0Htik3J/w@public.gmane.org To: zhangyanfei Return-path: Content-Disposition: inline In-Reply-To: <4F84E50E.2090008-BthXqXjhjHXQFUHtdCDX3A@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: kexec-bounces-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org Errors-To: kexec-bounces+glkk-kexec=m.gmane.org-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org List-Id: kvm.vger.kernel.org On Wed, Apr 11, 2012 at 09:57:34AM +0800, zhangyanfei wrote: > This patch creates sysfs file to export where VMCSINFO is allocated, > as below: > $ cat /sys/kernel/vmcsinfo > 1cb88a0 2000 > number on the left-hand side is the physical address of VMCSINFO, > while the one on the right-hand side is the max size of VMCSINFO. Ick, why do you have 2 values in one sysfs file, that's not nice, or good. What's wrong with 2 different files? Also, any new sysfs file you add needs to also have a Documentation/ABI entry added as well. But we can't accept this as-is, sorry, please split it up into 2 files. greg k-h From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758107Ab2DLXBF (ORCPT ); Thu, 12 Apr 2012 19:01:05 -0400 Received: from mail-pz0-f52.google.com ([209.85.210.52]:64548 "EHLO mail-pz0-f52.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757038Ab2DLXBD (ORCPT ); Thu, 12 Apr 2012 19:01:03 -0400 Date: Thu, 12 Apr 2012 16:00:58 -0700 From: Greg KH To: zhangyanfei Cc: avi@redhat.com, mtosatti@redhat.com, ebiederm@xmission.com, luto@mit.edu, joerg.roedel@amd.com, dzickus@redhat.com, paul.gortmaker@windriver.com, gregkh@suse.de, ludwig.nussel@suse.de, linux-kernel@vger.kernel.org, kvm@vger.kernel.org, kexec@lists.infradead.org Subject: Re: [PATCH 3/4] ksysfs: export VMCSINFO via sysfs Message-ID: <20120412230058.GA23292@kroah.com> References: <4F84E0DF.8040206@cn.fujitsu.com> <4F84E50E.2090008@cn.fujitsu.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4F84E50E.2090008@cn.fujitsu.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Apr 11, 2012 at 09:57:34AM +0800, zhangyanfei wrote: > This patch creates sysfs file to export where VMCSINFO is allocated, > as below: > $ cat /sys/kernel/vmcsinfo > 1cb88a0 2000 > number on the left-hand side is the physical address of VMCSINFO, > while the one on the right-hand side is the max size of VMCSINFO. Ick, why do you have 2 values in one sysfs file, that's not nice, or good. What's wrong with 2 different files? Also, any new sysfs file you add needs to also have a Documentation/ABI entry added as well. But we can't accept this as-is, sorry, please split it up into 2 files. greg k-h