From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Axel Lin <axel.lin@gmail.com>
Cc: linux-kernel@vger.kernel.org,
Linus Walleij <linus.walleij@stericsson.com>,
Liam Girdwood <lrg@ti.com>
Subject: Re: [PATCH RFT 1/3] regulator: ab3100: Add dummy set_suspend_[enable|disable] callbacks implementation
Date: Fri, 13 Apr 2012 09:16:07 +0100 [thread overview]
Message-ID: <20120413081607.GA3168@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <1334292098.6122.1.camel@phoenix>
[-- Attachment #1: Type: text/plain, Size: 475 bytes --]
On Fri, Apr 13, 2012 at 12:41:38PM +0800, Axel Lin wrote:
> Without the implementation of set_suspend_enable and set_suspend_disable callbacks,
> the regulator core won't call set_suspend_voltage.
>
> Thus add dummy implementation for set_suspend_[enable|disable] callbacks.
No, if we need to go adding dummy functions to a bunch of drivers we're
clearly going about things the wrong way and should be avoiding the need
to have those functions in the first place.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
prev parent reply other threads:[~2012-04-13 8:16 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-13 4:41 [PATCH RFT 1/3] regulator: ab3100: Add dummy set_suspend_[enable|disable] callbacks implementation Axel Lin
2012-04-13 4:42 ` [PATCH RFT 2/3] regulator: wm831x-dcdc: " Axel Lin
2012-04-13 4:43 ` [PATCH RFT 3/3] regulator: wm831x-ldo: " Axel Lin
2012-04-13 8:16 ` Mark Brown [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120413081607.GA3168@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=axel.lin@gmail.com \
--cc=linus.walleij@stericsson.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lrg@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.