From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH 00/14] intel_ringbuffer.c reorg + cleanups Date: Fri, 13 Apr 2012 12:56:44 +0200 Message-ID: <20120413105644.GE4525@phenom.ffwll.local> References: <1334175179-1514-1-git-send-email-daniel.vetter@ffwll.ch> <87aa2hkf8q.fsf@eliezer.anholt.net> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail-wg0-f43.google.com (mail-wg0-f43.google.com [74.125.82.43]) by gabe.freedesktop.org (Postfix) with ESMTP id ED35D9E737 for ; Fri, 13 Apr 2012 03:55:51 -0700 (PDT) Received: by wgbdr12 with SMTP id dr12so2350724wgb.12 for ; Fri, 13 Apr 2012 03:55:51 -0700 (PDT) Content-Disposition: inline In-Reply-To: <87aa2hkf8q.fsf@eliezer.anholt.net> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Eric Anholt Cc: Daniel Vetter , Intel Graphics Development List-Id: intel-gfx@lists.freedesktop.org On Wed, Apr 11, 2012 at 04:42:13PM -0700, Eric Anholt wrote: > On Wed, 11 Apr 2012 22:12:45 +0200, Daniel Vetter wrote: > > Hi all, > > > > This patch series is inspired by Ben's ring->get|put_irq cleanup for gen6+ and > > my perpetual hatred for intel_ringbuffer.c. > > > > It's a lot of churn, but the end result is imho worth it - I almost started to > > like what the ringbuffer abstraction looks like now. There are some follow-up > > cleanups possible, but I think that can wait until we've cleanup up our domain > > tracking and ripped out the flushing_list (if that ever happens). > > > > Commments, flames and review highly welcome. > > This is so nice. It's way better than the series I started with when > working on domain tracking lobotomy. tbh it's far from my first attempt at this, and I've dodged the domain tracking things mostly by leaving the ring->flush code as-is. > Except for a s/bds/bsd/ in patch 4's commit message, Fixed, same for the s/ring->flush/ring->add_request/ noticed by Ben. > Reviewed-by: Eric Anholt Thanks for the review, all queued for -next. Imo Ben's concerns are valid, but better tackled in follow up patches. -Daniel -- Daniel Vetter Mail: daniel@ffwll.ch Mobile: +41 (0)79 365 57 48