All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jonathan Nieder <jrnieder@gmail.com>
To: Felipe Contreras <felipe.contreras@gmail.com>
Cc: git@vger.kernel.org, "SZEDER Gábor" <szeder@ira.uka.de>,
	"Junio C Hamano" <gitster@pobox.com>,
	"Thomas Rast" <trast@student.ethz.ch>,
	"Jeff King" <peff@peff.net>
Subject: Re: [PATCH v2 4/4] completion: improve 'git --exec-path' completion
Date: Fri, 13 Apr 2012 18:37:06 -0500	[thread overview]
Message-ID: <20120413233706.GD13995@burratino> (raw)
In-Reply-To: <CAMP44s0R7imiem4uoBggkjjJ4z5+MXVYUroe_23JE8McMCk2sQ@mail.gmail.com>

Felipe Contreras wrote:

> I don't understand, the commit message doesn't match what the patch
> actually does.

Try it, I guess?  At least for me,

	git --exec-p<TAB>

completes to

	git --exec-path <cursor here>

before the patch, and to

	git --exec-path<cursor here>

after the patch.  Which is different from your original patch.

Cheers,
Jonathan

  reply	other threads:[~2012-04-13 23:37 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-04-12 23:49 [PATCH v2 0/4] completion: trivial cleanups and fixes Felipe Contreras
2012-04-12 23:50 ` [PATCH v2 1/4] completion: simplify __gitcomp_1 Felipe Contreras
2012-04-12 23:50 ` [PATCH v2 2/4] completion: trivial simplification Felipe Contreras
2012-04-12 23:50 ` [PATCH v2 3/4] completion: add missing general options Felipe Contreras
2012-04-12 23:50 ` [PATCH v2 4/4] completion: improve 'git --exec-path' completion Felipe Contreras
2012-04-13  6:08   ` Jonathan Nieder
2012-04-13 18:04     ` Jonathan Nieder
2012-04-13 18:30       ` Jonathan Nieder
2012-04-13 23:35         ` Felipe Contreras
2012-04-13 23:37           ` Jonathan Nieder [this message]
2012-04-13 23:43             ` Felipe Contreras
2012-04-14  7:21         ` Andreas Schwab

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120413233706.GD13995@burratino \
    --to=jrnieder@gmail.com \
    --cc=felipe.contreras@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=peff@peff.net \
    --cc=szeder@ira.uka.de \
    --cc=trast@student.ethz.ch \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.