From: Antonio Quartulli <ordex@autistici.org>
To: b.a.t.m.a.n@lists.open-mesh.org
Subject: Re: [B.A.T.M.A.N.] [PATCH 0/2] Fixes reported by Al Viro
Date: Sat, 14 Apr 2012 13:29:15 +0200 [thread overview]
Message-ID: <20120414112915.GA24739@ritirata.org> (raw)
In-Reply-To: <1334402127-5211-1-git-send-email-ordex@autistici.org>
[-- Attachment #1: Type: text/plain, Size: 958 bytes --]
On Sat, Apr 14, 2012 at 01:15:25PM +0200, Antonio Quartulli wrote:
> The following two patches fix the two issues found by Al Viro and reported in
> his email.
>
> Patch 1) simply convert the tt_crc field in the bat_priv structure from atomic_t
> to uint16_t. Actually there is no reason to declare it as atomic_t.
>
> Patch 2) fixes a little bug we have when sending a tt_request message: now we
> don't convert the tt_crc that we are sending within the request to network
> order. OTOH we convert this field from NO to HO on the receiver side.
>
> Therefore, nodes on the path of the request, which have HO different from NO,
> will fail to reply to the request and will forward it towards the final
> destination.
I think David'd want to see this fix in the next pull request or so...should we
commit these patches to next directly?
Cheers,
--
Antonio Quartulli
..each of us alone is worth nothing..
Ernesto "Che" Guevara
[-- Attachment #2: Type: application/pgp-signature, Size: 490 bytes --]
next prev parent reply other threads:[~2012-04-14 11:29 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-14 11:15 [B.A.T.M.A.N.] [PATCH 0/2] Fixes reported by Al Viro Antonio Quartulli
2012-04-14 11:15 ` [B.A.T.M.A.N.] [PATCH 1/2] batman-adv: convert bat_priv->tt_crc from atomic_t to uint16_t Antonio Quartulli
2012-04-17 8:32 ` Marek Lindner
2012-04-14 11:15 ` [B.A.T.M.A.N.] [PATCH 2/2] batman-adv: convert the tt_crc to network order Antonio Quartulli
2012-04-17 8:48 ` Marek Lindner
2012-04-14 11:29 ` Antonio Quartulli [this message]
2012-04-14 11:34 ` [B.A.T.M.A.N.] [PATCH 0/2] Fixes reported by Al Viro Marek Lindner
2012-04-14 11:41 ` Antonio Quartulli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120414112915.GA24739@ritirata.org \
--to=ordex@autistici.org \
--cc=b.a.t.m.a.n@lists.open-mesh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.