From: Clemens Buchacher <drizzd@aon.at>
To: Ross Lagerwall <rosslagerwall@gmail.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] clean: add --null option
Date: Sat, 14 Apr 2012 21:38:35 +0200 [thread overview]
Message-ID: <20120414193833.GA29999@ecki> (raw)
In-Reply-To: <1334426158-13607-1-git-send-email-rosslagerwall@gmail.com>
On Sat, Apr 14, 2012 at 07:55:58PM +0200, Ross Lagerwall wrote:
>
> Add a --null (-z) option to git-clean which prints out the files
> and directories separated with a NUL character rather than '\n'.
> This makes it useful in conjunction with xargs -0.
Thanks. Looks sensible to me.
> - printf(_("Removing %s\n"), qname);
> + print_path(_("Removing %s\n"), qname,
> + use_nul);
Although exceeding the 80 column boundary, I think this would be more
readable without line break. If we want to stay within 80 columns, I
don't think you can use 5 levels of indentation at the same time.
You could also make use_nul a static global, although it probably does
not improve the situation much.
prev parent reply other threads:[~2012-04-14 19:39 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-14 17:55 [PATCH] clean: add --null option Ross Lagerwall
2012-04-14 19:38 ` Clemens Buchacher [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120414193833.GA29999@ecki \
--to=drizzd@aon.at \
--cc=git@vger.kernel.org \
--cc=rosslagerwall@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.