Re: [PATCH] perf tools: Add 'G' and 'H' modifiers to event parsing

[Gleb Natapov <gleb@redhat.com>]

On Sun, Apr 15, 2012 at 05:12:22PM +0200, Peter Zijlstra wrote:
> On Sun, 2012-04-15 at 17:59 +0300, Gleb Natapov wrote:
> > -modifier_event [ukhp]{1,5}
> > +modifier_event [ukhpGH]{1,5} 
> 
> You'd also need to increase the 5 to 7 I think, unless there's a clear
> exclusion with some of the other flags.
> 
> Hmm, as it stands I think the 5 is already too low: "ukhppp" is 6.
> 
> We should really write this as ['u'] ['k'] ['h'] ['G'] ['H'] ['p'{1,3}],
> not the combined thing.
If we will write them like that they all will have to be present for
successful match of modifier_event, no?

--
			Gleb.