All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@kernel.org>
To: Andreas Herrmann <andreas.herrmann3@amd.com>
Cc: "H. Peter Anvin" <hpa@zytor.com>,
	Thomas Gleixner <tglx@linutronix.de>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] x86, amd: Re-enable CPU topology extensions in case BIOS has disabled it
Date: Mon, 16 Apr 2012 08:52:49 +0200	[thread overview]
Message-ID: <20120416065249.GA5292@gmail.com> (raw)
In-Reply-To: <20120411152640.GC4794@alberich.amd.com>


* Andreas Herrmann <andreas.herrmann3@amd.com> wrote:

> 
> For detection of thread siblings we are relying on the topology
> extension CPUID leafs. Thus we have to re-enable it in case BIOS tries
> to hide the correpsonding CPUID feature flag.
> 
> Cc: stable@vger.kernel.org
> Signed-off-by: Andreas Herrmann <andreas.herrmann3@amd.com>

This changelog is missing some key information:

 - how did you find the bug - did you see some actual badness?

 - what practical effect (if any) did you see from this patch?

 - what practical effect (if any) do you expect others to see from this patch?

This kind of information helps us prioritize bugfixes and helps 
us determine whether a fix requires a -stable backport.

Thanks,

    Ingo

  reply	other threads:[~2012-04-16  6:53 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-04-11 15:26 [PATCH] x86, amd: Re-enable CPU topology extensions in case BIOS has disabled it Andreas Herrmann
2012-04-16  6:52 ` Ingo Molnar [this message]
2012-04-16 13:40   ` [PATCH v2] " Andreas Herrmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120416065249.GA5292@gmail.com \
    --to=mingo@kernel.org \
    --cc=andreas.herrmann3@amd.com \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.