From: Stephen Hemminger <shemminger@vyatta.com>
To: Denys Fedoryshchenko <denys@visp.net.lb>
Cc: Stian Skjelstad <stian@nixia.no>, <eric.dumazet@gmail.com>,
<stephen.hemminger@vyatta.com>, <netdev@vger.kernel.org>
Subject: Re: Netlink, route monitoring, RTM_DELROUTE not issued for ppp peer address. Bug or feature?
Date: Mon, 16 Apr 2012 08:19:54 -0700 [thread overview]
Message-ID: <20120416081954.1bb994db@nehalam.linuxnetplumber.net> (raw)
In-Reply-To: <3db49d4a58321a5e185cd67335a60c81@visp.net.lb>
On Mon, 16 Apr 2012 13:37:14 +0300
Denys Fedoryshchenko <denys@visp.net.lb> wrote:
> After digging the code, i came to conclusion:
> fib_del_ifaddr, will check if deleted address are exist as prefsrc or
> interface are shut down, they will do fi->fib_flags |= RTNH_F_DEAD;
> Then fib_flush -> fib_table_flush -> trie_flush_leaf -> trie_flush_list
> will delete such routes.
> But trie_flush_list won't notify over netlink that route are deleted.
>
> So the only solution is to fetch first, then keep full routing table in
> userspace also, and keep tracking if local addresses deleted, and do the
> same in userspace and check for prefsrc...
>
> Maybe it should be fixed? E.g. netlink message sent when any route are
> deleted, even over the flush
>
> On 2012-04-13 16:59, Stian Skjelstad wrote:
> > I've seen the same issue, and got no response so far to that very
> > same question. Have you tested this on older kernels? I have worked
> > around this issue by testing my local copy of routing entries that
> > use
> > 'via'. If they are not routable when after the RTM_DELROUTE event, I
> > autoremove them from my local copy.
> >
> > Stian Skjelstad
> >
Looking at Quagga, it knows that deleting interface address
removes connected routes and silently cleans up.
You have to be really careful here making any changes to not break
applications that expect existing behavior.
next prev parent reply other threads:[~2012-04-16 15:19 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-13 12:10 Netlink, route monitoring, RTM_DELROUTE not issued for ppp peer address. Bug or feature? Denys Fedoryshchenko
2012-04-13 13:59 ` SV: " Stian Skjelstad
2012-04-16 10:37 ` Denys Fedoryshchenko
2012-04-16 15:19 ` Stephen Hemminger [this message]
2012-04-16 16:48 ` Denys Fedoryshchenko
2012-04-16 20:21 ` Stian Skjelstad
2012-04-16 21:00 ` Stephen Hemminger
2012-04-17 8:24 ` David Lamparter
2012-04-16 18:40 ` SV: " David Miller
2012-04-16 19:11 ` Denys Fedoryshchenko
2012-04-16 19:29 ` Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120416081954.1bb994db@nehalam.linuxnetplumber.net \
--to=shemminger@vyatta.com \
--cc=denys@visp.net.lb \
--cc=eric.dumazet@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=stephen.hemminger@vyatta.com \
--cc=stian@nixia.no \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.