Re: kvm: RCU warning in async pf

[Gleb Natapov <gleb@redhat.com>]

On Mon, Apr 16, 2012 at 03:27:20PM +0200, Peter Zijlstra wrote:
> On Mon, 2012-04-16 at 15:18 +0200, Peter Zijlstra wrote:
> > On Mon, 2012-04-16 at 16:08 +0300, Gleb Natapov wrote:
> > > On Mon, Apr 16, 2012 at 03:05:48PM +0200, Peter Zijlstra wrote:
> > > > On Mon, 2012-04-16 at 15:58 +0300, Gleb Natapov wrote:
> > > > > -               rcu_irq_enter();
> > > > > +               irq_enter();
> > > > >                 exit_idle(); 
> > > > 
> > > > Do we really need the exit_idle()? I can't remember other interrupt
> > > > handlers doing that.
> > > They do. That's where I got the idea.
> > 
> > Some do.. some don't.. /me goes have a look what this exit_idle nonsense
> > is all about. Looks to be something broken.
> 
> Yeah, its broken and the whole implementation is crap anyway. There's
> only one user (drivers/idle/i7300_idle.c) so it likely doesn't matter
> (much) anyway.
> 
Should I resend the patch with removal of exit_idle() call or it will
be removed by a patch that removes exit_idle() completely later?

> Thomas, can we rip that stuff out? or do we have to like actually fix
> it?

--
			Gleb.