From mboxrd@z Thu Jan 1 00:00:00 1970 From: Konrad Rzeszutek Wilk Subject: Re: [PATCH] xen_disk: implement BLKIF_OP_FLUSH_DISKCACHE, remove BLKIF_OP_WRITE_BARRIER Date: Mon, 16 Apr 2012 13:10:21 -0400 Message-ID: <20120416171021.GG9925@phenom.dumpdata.com> References: <1334595957-12552-1-git-send-email-stefano.stabellini@eu.citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <1334595957-12552-1-git-send-email-stefano.stabellini@eu.citrix.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+gceq-qemu-devel=gmane.org@nongnu.org Sender: qemu-devel-bounces+gceq-qemu-devel=gmane.org@nongnu.org To: Stefano Stabellini Cc: kwolf@redhat.com, xen-devel@lists.xensource.com, qemu-devel@nongnu.org List-Id: xen-devel@lists.xenproject.org On Mon, Apr 16, 2012 at 06:05:57PM +0100, Stefano Stabellini wrote: > Signed-off-by: Stefano Stabellini Reviewed-by: Konrad Rzeszutek Wilk > --- > hw/xen_disk.c | 8 ++++---- > 1 files changed, 4 insertions(+), 4 deletions(-) > > diff --git a/hw/xen_disk.c b/hw/xen_disk.c > index 015d2af..3e4a47b 100644 > --- a/hw/xen_disk.c > +++ b/hw/xen_disk.c > @@ -183,12 +183,12 @@ static int ioreq_parse(struct ioreq *ioreq) > case BLKIF_OP_READ: > ioreq->prot = PROT_WRITE; /* to memory */ > break; > - case BLKIF_OP_WRITE_BARRIER: > + case BLKIF_OP_FLUSH_DISKCACHE: > if (!ioreq->req.nr_segments) { > ioreq->presync = 1; > return 0; > } > - ioreq->presync = ioreq->postsync = 1; > + ioreq->postsync = 1; > /* fall through */ > case BLKIF_OP_WRITE: > ioreq->prot = PROT_READ; /* from memory */ > @@ -354,7 +354,7 @@ static int ioreq_runio_qemu_aio(struct ioreq *ioreq) > qemu_aio_complete, ioreq); > break; > case BLKIF_OP_WRITE: > - case BLKIF_OP_WRITE_BARRIER: > + case BLKIF_OP_FLUSH_DISKCACHE: > if (!ioreq->req.nr_segments) { > break; > } > @@ -627,7 +627,7 @@ static int blk_init(struct XenDevice *xendev) > blkdev->file_size, blkdev->file_size >> 20); > > /* fill info */ > - xenstore_write_be_int(&blkdev->xendev, "feature-barrier", 1); > + xenstore_write_be_int(&blkdev->xendev, "feature-flush-cache", 1); > xenstore_write_be_int(&blkdev->xendev, "info", info); > xenstore_write_be_int(&blkdev->xendev, "sector-size", blkdev->file_blk); > xenstore_write_be_int(&blkdev->xendev, "sectors", > -- > 1.7.2.5