From: Ben Myers <bpm@sgi.com>
To: Jeff Liu <jeff.liu@oracle.com>
Cc: Christoph Hellwig <hch@infradead.org>, xfs@oss.sgi.com
Subject: Re: [PATCH v2] xfstests: Introduce test case 285 to check statfs(2) will not cause ASSERT(XFS_IS_QUOTA_RUNNING(mp)) failed.
Date: Mon, 16 Apr 2012 12:49:29 -0500 [thread overview]
Message-ID: <20120416174929.GD2924@sgi.com> (raw)
In-Reply-To: <4F87ED3D.5060105@oracle.com>
Jeff,
On Fri, Apr 13, 2012 at 05:09:17PM +0800, Jeff Liu wrote:
> Call statfs(2) against a project directory cause ASSERT(XFS_IS_QUOTA_RUNNING(mp)) at xfs_qm_dqget() failed pre-vanilla kernel-3.4
> if the "pquota" or "prjquota" mount option was not enabled on the underlying partition. This test case can help checking it.
A nice find.
> +echo "Silence is golden."
> +
> +# Modify as appropriate.
> +_supported_fs xfs
> +_supported_os Linux
> +_require_xfs_quota
> +_require_scratch
> +
> +proj_dir="${SCRATCH_MNT}/test_project"
> +test_file="${proj_dir}/test_file"
> +
> +_scratch_mkfs_xfs >/dev/null 2>&1
> +_qmount
> +
> +mkdir $proj_dir
> +touch $test_file
> +
> +$XFS_QUOTA_PROG -x -c "project -s -p ${proj_dir} 2012" $SCRATCH_DEV \
> + >/dev/null 2>&1
> +du -sh $proj_dir >/dev/null 2>&1
I was unable to reproduce this until I changed 'du -sh' to 'df'. Now it does
crash consistently without your fix for xfs_fs_statfs().
With that change you can consider this
Reviewed-by: Ben Myers <bpm@sgi.com>
-Ben
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2012-04-16 17:47 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-13 9:09 [PATCH v2] xfstests: Introduce test case 285 to check statfs(2) will not cause ASSERT(XFS_IS_QUOTA_RUNNING(mp)) failed Jeff Liu
2012-04-16 16:31 ` Ben Myers
2012-04-16 17:49 ` Ben Myers [this message]
2012-04-17 6:29 ` Jeff Liu
2012-06-02 14:27 ` Jeff Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120416174929.GD2924@sgi.com \
--to=bpm@sgi.com \
--cc=hch@infradead.org \
--cc=jeff.liu@oracle.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.