All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dan Carpenter <dan.carpenter@oracle.com>
To: "Justin P. Mattock" <justinmattock@gmail.com>
Cc: gregkh@linuxfoundation.org, devel@driverdev.osuosl.org,
	linux-kernel@vger.kernel.org, lacombar@gmail.com
Subject: Re: [PATCH v2]NEXT:drivers:staging:rtl8187se Fix typos in staging:rtl8187se
Date: Mon, 16 Apr 2012 20:50:29 +0300	[thread overview]
Message-ID: <20120416175029.GF6498@mwanda> (raw)
In-Reply-To: <1334589703-15707-1-git-send-email-justinmattock@gmail.com>

On Mon, Apr 16, 2012 at 08:21:43AM -0700, Justin P. Mattock wrote:
> From: "Justin P. Mattock" <Justin P. Mattock>
> 
> RESEND: resending this patch because my email was mangled with gitconfig.
> The below patch fixes some typos that I found while reading. 
> 

It's still messed up as pants.  Here is what it looks like when you
do a `cat email.txt | git am ; git log`

commit c8cc1d3bc3e18d92ce14fa233008d299c1d7355a
Author: Justin P. Mattock <Justin P. Mattock>
Date:   Mon Apr 16 08:21:43 2012 -0700

    NEXT:drivers:staging:rtl8187se Fix typos in staging:rtl8187se
    
    RESEND: resending this patch because my email was mangled with gitconfig.
    The below patch fixes some typos that I found while reading.
    
    Signed-off-by: Justin P. Mattock <justinmattock@gmail.com>

Your email address is screwed up.

Put the NEXT inside the square brackets with the [patch], but
actually you can just leave it out because everything should apply
to -next.  This clearly isn't a critical bugfix.

The subject prefix should be:  "Staging: rtl8187se:"  Do a "git log
--pretty=oneline " to find this.  Put the commentry the doesn't
belong in the log under the --- line with the diffstat.

regards,
dan carpenter


      reply	other threads:[~2012-04-16 17:48 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-04-16 15:21 [PATCH v2]NEXT:drivers:staging:rtl8187se Fix typos in staging:rtl8187se Justin P. Mattock
2012-04-16 17:50 ` Dan Carpenter [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120416175029.GF6498@mwanda \
    --to=dan.carpenter@oracle.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=justinmattock@gmail.com \
    --cc=lacombar@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.