All of lore.kernel.org
 help / color / mirror / Atom feed
From: Oleg Nesterov <oleg@redhat.com>
To: Serge Hallyn <serge.hallyn@canonical.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
	Daniel Lezcano <daniel.lezcano@free.fr>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] pidns: reboot_pid_ns: use SEND_SIG_FORCED instead of force_sig()
Date: Mon, 16 Apr 2012 23:26:06 +0200	[thread overview]
Message-ID: <20120416212606.GA27490@redhat.com> (raw)
In-Reply-To: <20120416162402.GA7995@sergelap>

On 04/16, Serge Hallyn wrote:
>
> Quoting Oleg Nesterov (oleg@redhat.com):
> > On 04/16, Serge Hallyn wrote:
> > >
> > > Quoting Oleg Nesterov (oleg@redhat.com):
> > > >
> > > > Strange... I even tested this change, but only in the root namespace.
> > > > OK, thanks, I'll investigate. I hope you verified your kernel has
> > > > 629d362b commit ;)
> > >
> > > I took friday's HEAD of Linus tree.  All went fine.  Added this patch.
> > > The container can shutdown, but reboot causes shutdown.  Don't undersrtand
> > > why.
> >
> > Heh. This looks "impossible". I'd like to understand the reason.
> > So, LINUX_REBOOT_CMD_RESTART results in WIFSIGNALED() == SIGINT?
> >
> > OK, I'll try to test this patch in the non-root namespace.
>
> Playing with the test case below (based on the one Daniel submitted
> alongside his container reboot patches), it looks like
> WIFSIGNALED(status) and WTERMSIG(status) are 0 with this kernel, not
> 1 and sig.

Great, thanks Serge. I'll investigate and report tomorrow.

Oleg.


  reply	other threads:[~2012-04-16 21:26 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-04-13  0:44 [PATCH] pidns: reboot_pid_ns: use SEND_SIG_FORCED instead of force_sig() Oleg Nesterov
2012-04-13 18:20 ` Serge Hallyn
2012-04-13 19:24   ` Oleg Nesterov
2012-04-13 19:34     ` Serge Hallyn
2012-04-16 13:59     ` Serge Hallyn
2012-04-16 15:38       ` Oleg Nesterov
2012-04-16 16:24         ` Serge Hallyn
2012-04-16 21:26           ` Oleg Nesterov [this message]
2012-04-17 18:35             ` Oleg Nesterov
2012-04-18  2:29               ` Serge E. Hallyn

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120416212606.GA27490@redhat.com \
    --to=oleg@redhat.com \
    --cc=akpm@linux-foundation.org \
    --cc=daniel.lezcano@free.fr \
    --cc=linux-kernel@vger.kernel.org \
    --cc=serge.hallyn@canonical.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.