From mboxrd@z Thu Jan  1 00:00:00 1970
From: Daniel Vetter <daniel@ffwll.ch>
Subject: Re: [PATCH] drm/i915/dp: Flush any outstanding work to
 turn the VDD off
Date: Mon, 16 Apr 2012 23:53:18 +0200
Message-ID: <20120416215318.GI4199@phenom.ffwll.local>
References: <1334585913-9831-1-git-send-email-chris@chris-wilson.co.uk>
	<20120416203951.GH4199@phenom.ffwll.local>
	<1334610116_9592@CP5-2952>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org>
Received: from mail-we0-f177.google.com (mail-we0-f177.google.com
	[74.125.82.177])
	by gabe.freedesktop.org (Postfix) with ESMTP id 458AB9E94F
	for <intel-gfx@lists.freedesktop.org>;
	Mon, 16 Apr 2012 14:52:23 -0700 (PDT)
Received: by werp11 with SMTP id p11so4409720wer.36
	for <intel-gfx@lists.freedesktop.org>;
	Mon, 16 Apr 2012 14:52:22 -0700 (PDT)
Content-Disposition: inline
In-Reply-To: <1334610116_9592@CP5-2952>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
To: Chris Wilson <chris@chris-wilson.co.uk>
Cc: intel-gfx@lists.freedesktop.org
List-Id: intel-gfx@lists.freedesktop.org

On Mon, Apr 16, 2012 at 10:01:42PM +0100, Chris Wilson wrote:
> On Mon, 16 Apr 2012 22:39:51 +0200, Daniel Vetter <daniel@ffwll.ch> wrote:
> > On Mon, Apr 16, 2012 at 03:18:33PM +0100, Chris Wilson wrote:
> > > As we may kick off a delayed workqueue task to switch of the VDD lines, we
> > > need to complete that task prior to turning off the panel (which itself
> > > depends upon VDD being off).
> > > 
> > > Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> > > Cc: Keith Packard <keithp@keithp.com>
> > 
> > I've looked a bit at this and I think we just need a call to
> > ironlake_panel_vdd_off_sync instead of the WARN. The work will do the
> > right thing when the vdd is already off, so no problem there.
> 
> The WARN is valid and did help to document the design of the code.
> Good point about the cancel_sync taking the mutex again, oops, and
> indeed all we need here is just the call to sync.

Oops, yeah I've misread what want_panle_vdd means, the WARN looks good
as-is.
-Daniel
-- 
Daniel Vetter
Mail: daniel@ffwll.ch
Mobile: +41 (0)79 365 57 48