From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tejun Heo Subject: Re: [PATCH 2/7] memcg: move charge to parent only when necessary. Date: Mon, 16 Apr 2012 15:21:19 -0700 Message-ID: <20120416222119.GC12421@google.com> References: <4F86B9BE.8000105@jp.fujitsu.com> <4F86BAB0.5030809@jp.fujitsu.com> Mime-Version: 1.0 Return-path: DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-type:content-disposition:in-reply-to:user-agent; bh=9PG+MkbYjIESrpGxWXyiEzN50CEjQw+AKP867ulpnIc=; b=wqalZpxj85v8Pw1ef80P8xoWaAeqAZNaalgqDjQovdr+HmrGtAQS5qmP80XRwAcy9w 6FEiOnEeoOrfMxCkYWrkgv3QLQED4lSaFjhHaUFxhbUOl0ip1Mju7wO1lsrcMN5B0yCJ 0fBygD1o23f/mminFHBEWiBGraPiYd0vJL/TxrtsekgrbWYfq+sNlCpVCdIQ11OyYbNl dwsxoZG1DDdVUjGwfOZxSYiKlyFMux/fiF/0L+/qxQWOZWtKgneo0hmS1j2uWDGecq0Q YuwSMo2HUb/mg4asET0T7jwUB+tYl1z+HMZwuTy9bcE2UtgpkfpO6slqz5+RN+Qaz9LJ NBhA== Content-Disposition: inline In-Reply-To: <4F86BAB0.5030809-+CUm20s59erQFUHtdCDX3A@public.gmane.org> Sender: cgroups-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-ID: Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: KAMEZAWA Hiroyuki Cc: "linux-mm-Bw31MaZKKs3YtjvyW6yDsg@public.gmane.org" , "cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , Michal Hocko , Johannes Weiner , Glauber Costa , Hugh Dickins , Andrew Morton On Thu, Apr 12, 2012 at 08:21:20PM +0900, KAMEZAWA Hiroyuki wrote: > > When memcg->use_hierarchy==true, the parent res_counter includes > the usage in child's usage. So, it's not necessary to call try_charge() > in the parent. > > Signed-off-by: KAMEZAWA Hiroyuki > --- > mm/memcontrol.c | 39 ++++++++++++++++++++++++++++++++------- > 1 files changed, 32 insertions(+), 7 deletions(-) > > diff --git a/mm/memcontrol.c b/mm/memcontrol.c > index fa01106..3215880 100644 > --- a/mm/memcontrol.c > +++ b/mm/memcontrol.c > @@ -2409,6 +2409,20 @@ static void __mem_cgroup_cancel_charge(struct mem_cgroup *memcg, > res_counter_uncharge(&memcg->memsw, bytes); > } > } New line missing here. > +/* > + * Moving usage between a child to its parent if use_hierarchy==true. > + */ Prolly "from a child to its parent"? Thanks. -- tejun From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from psmtp.com (na3sys010amx103.postini.com [74.125.245.103]) by kanga.kvack.org (Postfix) with SMTP id EBFE16B0044 for ; Mon, 16 Apr 2012 18:21:24 -0400 (EDT) Received: by pbcup15 with SMTP id up15so8629208pbc.14 for ; Mon, 16 Apr 2012 15:21:24 -0700 (PDT) Date: Mon, 16 Apr 2012 15:21:19 -0700 From: Tejun Heo Subject: Re: [PATCH 2/7] memcg: move charge to parent only when necessary. Message-ID: <20120416222119.GC12421@google.com> References: <4F86B9BE.8000105@jp.fujitsu.com> <4F86BAB0.5030809@jp.fujitsu.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4F86BAB0.5030809@jp.fujitsu.com> Sender: owner-linux-mm@kvack.org List-ID: To: KAMEZAWA Hiroyuki Cc: "linux-mm@kvack.org" , "cgroups@vger.kernel.org" , Michal Hocko , Johannes Weiner , Glauber Costa , Hugh Dickins , Andrew Morton On Thu, Apr 12, 2012 at 08:21:20PM +0900, KAMEZAWA Hiroyuki wrote: > > When memcg->use_hierarchy==true, the parent res_counter includes > the usage in child's usage. So, it's not necessary to call try_charge() > in the parent. > > Signed-off-by: KAMEZAWA Hiroyuki > --- > mm/memcontrol.c | 39 ++++++++++++++++++++++++++++++++------- > 1 files changed, 32 insertions(+), 7 deletions(-) > > diff --git a/mm/memcontrol.c b/mm/memcontrol.c > index fa01106..3215880 100644 > --- a/mm/memcontrol.c > +++ b/mm/memcontrol.c > @@ -2409,6 +2409,20 @@ static void __mem_cgroup_cancel_charge(struct mem_cgroup *memcg, > res_counter_uncharge(&memcg->memsw, bytes); > } > } New line missing here. > +/* > + * Moving usage between a child to its parent if use_hierarchy==true. > + */ Prolly "from a child to its parent"? Thanks. -- tejun -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/ Don't email: email@kvack.org