From: Dan Carpenter <dan.carpenter@oracle.com>
To: kernel-janitors@vger.kernel.org
Subject: Re: [Q] warning BUG() related fixing and janitors question
Date: Mon, 16 Apr 2012 22:31:38 +0000 [thread overview]
Message-ID: <20120416223138.GA22294@elgon.mountain> (raw)
In-Reply-To: <CALF0-+VyPmN03xhkQ_aQf_Zdc+J=DT1_MvKzQCVri4Fwbi83RQ@mail.gmail.com>
On Mon, Apr 16, 2012 at 06:12:07PM -0300, Ezequiel García wrote:
> Hi Dan,
>
> 2012/4/16 Dan Carpenter <dan.carpenter@oracle.com>:
> >
> > Don't start messing in scheduler code if you have any doubts about
> > what you are doing. My advise is don't send a patch for this
> > warning. Most times people leave BUG() enabled so we don't really
> > care about the warning.
>
> Okey. Perhaps I picked the wrong example, there are a whole bunch of warnings
> related to the same BUG() stuff, here's a template example:
>
> void *p;
>
> switch (something) {
> case a:
> p = foo();
> case b:
> p = bar();
> default:
> BUG();
> }
>
> dosomething(p);
>
> --
>
> This will trigger warning "p could be used uninitialized" or something.
> I know most of us just leave BUG on, so you say these warnings aren't important?
Yeah. Probably best to ignore them.
regards,
dan carpenter
--
To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2012-04-16 22:31 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-16 19:03 [Q] warning BUG() related fixing and janitors question Ezequiel García
2012-04-16 20:57 ` Dan Carpenter
2012-04-16 21:12 ` Ezequiel García
2012-04-16 22:16 ` Marcin Ślusarz
2012-04-16 22:31 ` Dan Carpenter [this message]
2012-04-16 22:35 ` Ezequiel García
2012-04-16 23:13 ` Marcin Ślusarz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120416223138.GA22294@elgon.mountain \
--to=dan.carpenter@oracle.com \
--cc=kernel-janitors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.