From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mail-pb0-f49.google.com ([209.85.160.49]) by merlin.infradead.org with esmtps (Exim 4.76 #1 (Red Hat Linux)) id 1SJyC4-0000aS-RS for kexec@lists.infradead.org; Tue, 17 Apr 2012 02:31:01 +0000 Received: by pbcun4 with SMTP id un4so7675985pbc.36 for ; Mon, 16 Apr 2012 19:30:57 -0700 (PDT) Date: Mon, 16 Apr 2012 19:30:53 -0700 From: Greg KH Subject: Re: [PATCH 3/4] ksysfs: export VMCSINFO via sysfs Message-ID: <20120417023053.GA19491@kroah.com> References: <4F84E0DF.8040206@cn.fujitsu.com> <4F84E50E.2090008@cn.fujitsu.com> <20120412230058.GA23292@kroah.com> <4F8CCCEA.2090706@cn.fujitsu.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <4F8CCCEA.2090706@cn.fujitsu.com> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: kexec-bounces@lists.infradead.org Errors-To: kexec-bounces+dwmw2=infradead.org@lists.infradead.org To: zhangyanfei Cc: dzickus@redhat.com, luto@mit.edu, kvm@vger.kernel.org, joerg.roedel@amd.com, mtosatti@redhat.com, kexec@lists.infradead.org, linux-kernel@vger.kernel.org, paul.gortmaker@windriver.com, ludwig.nussel@suse.de, avi@redhat.com, ebiederm@xmission.com T24gVHVlLCBBcHIgMTcsIDIwMTIgYXQgMDk6NTI6NDJBTSArMDgwMCwgemhhbmd5YW5mZWkgd3Jv dGU6Cj4g5LqOIDIwMTLlubQwNOaciDEz5pelIDA3OjAwLCBHcmVnIEtIIOWGmemBkzoKPiA+IE9u IFdlZCwgQXByIDExLCAyMDEyIGF0IDA5OjU3OjM0QU0gKzA4MDAsIHpoYW5neWFuZmVpIHdyb3Rl Ogo+ID4+IFRoaXMgcGF0Y2ggY3JlYXRlcyBzeXNmcyBmaWxlIHRvIGV4cG9ydCB3aGVyZSBWTUNT SU5GTyBpcyBhbGxvY2F0ZWQsCj4gPj4gYXMgYmVsb3c6Cj4gPj4gICAgICAgICAkIGNhdCAvc3lz L2tlcm5lbC92bWNzaW5mbwo+ID4+ICAgICAgICAgMWNiODhhMCAyMDAwCj4gPj4gbnVtYmVyIG9u IHRoZSBsZWZ0LWhhbmQgc2lkZSBpcyB0aGUgcGh5c2ljYWwgYWRkcmVzcyBvZiBWTUNTSU5GTywK PiA+PiB3aGlsZSB0aGUgb25lIG9uIHRoZSByaWdodC1oYW5kIHNpZGUgaXMgdGhlIG1heCBzaXpl IG9mIFZNQ1NJTkZPLgo+ID4gCj4gPiBJY2ssIHdoeSBkbyB5b3UgaGF2ZSAyIHZhbHVlcyBpbiBv bmUgc3lzZnMgZmlsZSwgdGhhdCdzIG5vdCBuaWNlLCBvcgo+ID4gZ29vZC4KPiA+IAo+ID4gV2hh dCdzIHdyb25nIHdpdGggMiBkaWZmZXJlbnQgZmlsZXM/Cj4gPiAKPiAKPiBUaGUgcmVhc29uIHdo eSBJIHB1dCB0aGUgMiB2YWx1ZXMgaW4gb25lIHN5c2ZzIGZpbGUgaXMgdGhhdCB0aGVyZSBpcyBh IHNpbWlsYXIKPiBmaWxlICd2bWNvcmVpbmZvJyBpbiBzeXNmcy4KPiAgICAgICAgICMgY2F0IC9z eXMva2VybmVsL3ZtY29yZWluZm8gCj4gICAgICAgICAxZDc1MzgwIDEwMDAKClRoZW4gdGhhdCBz aG91bGQgYmUgZml4ZWQgYXMgd2VsbCwgdXNpbmcgdHdvIGRpZmZlcmVudCBmaWxlIG5hbWVzIG5v dyA6KAoKdGhhbmtzLAoKZ3JlZyBrLWgKCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fCmtleGVjIG1haWxpbmcgbGlzdAprZXhlY0BsaXN0cy5pbmZyYWRlYWQu b3JnCmh0dHA6Ly9saXN0cy5pbmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8va2V4ZWMK From mboxrd@z Thu Jan 1 00:00:00 1970 From: Greg KH Subject: Re: [PATCH 3/4] ksysfs: export VMCSINFO via sysfs Date: Mon, 16 Apr 2012 19:30:53 -0700 Message-ID: <20120417023053.GA19491@kroah.com> References: <4F84E0DF.8040206@cn.fujitsu.com> <4F84E50E.2090008@cn.fujitsu.com> <20120412230058.GA23292@kroah.com> <4F8CCCEA.2090706@cn.fujitsu.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Cc: avi@redhat.com, mtosatti@redhat.com, ebiederm@xmission.com, luto@mit.edu, joerg.roedel@amd.com, dzickus@redhat.com, paul.gortmaker@windriver.com, ludwig.nussel@suse.de, linux-kernel@vger.kernel.org, kvm@vger.kernel.org, kexec@lists.infradead.org To: zhangyanfei Return-path: Content-Disposition: inline In-Reply-To: <4F8CCCEA.2090706@cn.fujitsu.com> Sender: linux-kernel-owner@vger.kernel.org List-Id: kvm.vger.kernel.org On Tue, Apr 17, 2012 at 09:52:42AM +0800, zhangyanfei wrote: > =E4=BA=8E 2012=E5=B9=B404=E6=9C=8813=E6=97=A5 07:00, Greg KH =E5=86=99= =E9=81=93: > > On Wed, Apr 11, 2012 at 09:57:34AM +0800, zhangyanfei wrote: > >> This patch creates sysfs file to export where VMCSINFO is allocate= d, > >> as below: > >> $ cat /sys/kernel/vmcsinfo > >> 1cb88a0 2000 > >> number on the left-hand side is the physical address of VMCSINFO, > >> while the one on the right-hand side is the max size of VMCSINFO. > >=20 > > Ick, why do you have 2 values in one sysfs file, that's not nice, o= r > > good. > >=20 > > What's wrong with 2 different files? > >=20 >=20 > The reason why I put the 2 values in one sysfs file is that there is = a similar > file 'vmcoreinfo' in sysfs. > # cat /sys/kernel/vmcoreinfo=20 > 1d75380 1000 Then that should be fixed as well, using two different file names now := ( thanks, greg k-h