From: "Michael S. Tsirkin" <mst@redhat.com>
To: Jan Kiszka <jan.kiszka@siemens.com>
Cc: "kvm@vger.kernel.org" <kvm@vger.kernel.org>,
Marcelo Tosatti <mtosatti@redhat.com>,
Alex Williamson <alex.williamson@redhat.com>,
Avi Kivity <avi@redhat.com>
Subject: Re: [PATCHv2] device-assignment: don't touch real command register
Date: Tue, 17 Apr 2012 15:00:37 +0300 [thread overview]
Message-ID: <20120417120037.GA23957@redhat.com> (raw)
In-Reply-To: <4F8D52E8.8080403@siemens.com>
On Tue, Apr 17, 2012 at 01:24:24PM +0200, Jan Kiszka wrote:
> > + /* Pass bus master writes to device. */
> > + pci_dev->emulate_config_write[PCI_COMMAND] &= ~PCI_COMMAND_MASTER;
> > + pci_dev->emulate_config_write[PCI_COMMAND + 1] &= ~(PCI_COMMAND_INTX_DISABLE >> 8);
>
> Comment doesn't fully match the code.
Will fix.
> And I bet you aren't using
> checkpatch... ;)
I didn't run it but it doesn't complain.
prev parent reply other threads:[~2012-04-17 12:52 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-16 19:53 [PATCHv2] device-assignment: don't touch real command register Michael S. Tsirkin
2012-04-16 20:21 ` Alex Williamson
2012-04-17 11:24 ` Jan Kiszka
2012-04-17 11:25 ` Jan Kiszka
2012-04-17 12:00 ` Michael S. Tsirkin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120417120037.GA23957@redhat.com \
--to=mst@redhat.com \
--cc=alex.williamson@redhat.com \
--cc=avi@redhat.com \
--cc=jan.kiszka@siemens.com \
--cc=kvm@vger.kernel.org \
--cc=mtosatti@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.