From: majianpeng <majianpeng@gmail.com>
To: "Eric Dumazet" <eric.dumazet@gmail.com>
Cc: netdev <netdev@vger.kernel.org>
Subject: Re: Re: [PATCH] net/ipv4:Remove two memleak reports bykmemeleak_not_leak
Date: Tue, 17 Apr 2012 13:22:18 +0800 [thread overview]
Message-ID: <201204171322106565839@gmail.com> (raw)
In-Reply-To: 1334639930.2472.4.camel@edumazet-glaptop
Thanks,I will correct it and resent the patch.
------------------
majianpeng
2012-04-17
-------------------------------------------------------------
发件人:Eric Dumazet
发送日期:2012-04-17 13:18:54
收件人:majianpeng
抄送:netdev
主题:Re: [PATCH] net/ipv4:Remove two memleak reports bykmemeleak_not_leak
On Tue, 2012-04-17 at 09:41 +0800, majianpeng wrote:
> From 582ed93b990e88110287ed0388bcb9057b1b8591 Mon Sep 17 00:00:00 2001
> From: majianpeng <majianpeng@gmail.com>
> Date: Tue, 17 Apr 2012 09:36:26 +0800
> Subject: [PATCH] net/ipv4:Remove two memleak reports by kmemeleak_not_leak.
>
>
> Signed-off-by: majianpeng <majianpeng@gmail.com>
> ---
> net/ipv4/route.c | 8 ++++++--
> 1 files changed, 6 insertions(+), 2 deletions(-)
>
> diff --git a/net/ipv4/route.c b/net/ipv4/route.c
> index 167ea10..1984c82 100644
> --- a/net/ipv4/route.c
> +++ b/net/ipv4/route.c
> @@ -3504,7 +3504,11 @@ int __init ip_rt_init(void)
> * this nonsense will go away.
> */
> void __init ip_static_sysctl_init(void)
> -{
> - register_sysctl_paths(ipv4_path, ipv4_skeleton);
> +{
> + struct ctl_table_header *ctl_header;
> +
> + ctl_header = register_sysctl_paths(ipv4_path, ipv4_skeleton);
> + if (ctl_header)
> + kmemleak_not_leak(ctl_header);
> }
> #endif
No need for this temp var and conditional.
Just :
kmemleak_not_leak(register_sysctl_paths(ipv4_path, ipv4_skeleton));
prev parent reply other threads:[~2012-04-17 5:21 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-17 1:41 [PATCH] net/ipv4:Remove two memleak reports by kmemeleak_not_leak majianpeng
2012-04-17 5:18 ` Eric Dumazet
2012-04-17 5:22 ` majianpeng [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201204171322106565839@gmail.com \
--to=majianpeng@gmail.com \
--cc=eric.dumazet@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.