From: "Paul E. McKenney" <paulmck@linux.vnet.ibm.com>
To: Randy Dunlap <rdunlap@xenotime.net>
Cc: Stephen Rothwell <sfr@canb.auug.org.au>,
linux-next@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>,
paul.gortmaker@windriver.com
Subject: Re: linux-next: Tree for Apr 17 (rcu)
Date: Tue, 17 Apr 2012 09:32:32 -0700 [thread overview]
Message-ID: <20120417163232.GG2404@linux.vnet.ibm.com> (raw)
In-Reply-To: <4F8DBD14.5000100@xenotime.net>
On Tue, Apr 17, 2012 at 11:57:24AM -0700, Randy Dunlap wrote:
> On 04/16/2012 09:42 PM, Stephen Rothwell wrote:
>
> > Hi all,
> >
> > Changes since 20120416:
> >
> > The rcu tree lost its build failure.
>
>
> ERROR: "rcu_read_lock_nesting" [net/sctp/sctp.ko] undefined!
> ERROR: "rcu_read_lock_nesting" [net/rds/rds.ko] undefined!
> ERROR: "rcu_read_lock_nesting" [net/phonet/phonet.ko] undefined!
> ERROR: "rcu_read_lock_nesting" [net/openvswitch/openvswitch.ko] undefined!
> ERROR: "rcu_read_lock_nesting" [net/netfilter/xt_TCPMSS.ko] undefined!
> ERROR: "rcu_read_lock_nesting" [net/netfilter/nfnetlink.ko] undefined!
> ERROR: "rcu_read_lock_nesting" [net/netfilter/nf_conntrack.ko] undefined!
> ERROR: "rcu_read_lock_nesting" [net/netfilter/ipset/ip_set.ko] undefined!
> ERROR: "rcu_read_lock_nesting" [net/llc/llc2.ko] undefined!
> ERROR: "rcu_read_lock_nesting" [net/l2tp/l2tp_ip.ko] undefined!
> ERROR: "rcu_read_lock_nesting" [net/l2tp/l2tp_core.ko] undefined!
> ERROR: "rcu_read_lock_nesting" [net/key/af_key.ko] undefined!
> ERROR: "rcu_read_lock_nesting" [net/ipv4/ipip.ko] undefined!
> ERROR: "rcu_read_lock_nesting" [net/decnet/decnet.ko] undefined!
> ERROR: "rcu_read_lock_nesting" [net/core/netprio_cgroup.ko] undefined!
> ERROR: "rcu_read_lock_nesting" [net/can/can.ko] undefined!
> ERROR: "rcu_read_lock_nesting" [net/can/can-bcm.ko] undefined!
> ERROR: "rcu_read_lock_nesting" [net/bridge/bridge.ko] undefined!
> ERROR: "rcu_read_lock_nesting" [net/bluetooth/bluetooth.ko] undefined!
> ERROR: "rcu_read_lock_nesting" [net/batman-adv/batman-adv.ko] undefined!
> ERROR: "rcu_read_lock_nesting" [net/atm/atm.ko] undefined!
> ERROR: "rcu_read_lock_nesting" [fs/gfs2/gfs2.ko] undefined!
> ERROR: "rcu_read_lock_nesting" [drivers/net/vmxnet3/vmxnet3.ko] undefined!
> ERROR: "rcu_read_lock_nesting" [drivers/input/joydev.ko] undefined!
> ERROR: "rcu_read_lock_nesting" [drivers/char/tpm/tpm.ko] undefined!
> ERROR: "rcu_read_lock_nesting" [drivers/char/ipmi/ipmi_msghandler.ko] undefined!
> ERROR: "rcu_read_lock_nesting" [block/cfq-iosched.ko] undefined!
> ERROR: "rcu_read_lock_nesting" [block/blk-cgroup.ko] undefined!
>
> on i386.
>
> Full randconfig file is attached.
Sigh! I failed to add the exports. Please see the following
not-yet-tested patch.
Thanx, Paul
------------------------------------------------------------------------
rcu: Add exports for per-CPU variables used for inlining
The new rcu_read_lock_nesting and rcu_read_unlock_special per-CPU
variables need to be accessible from modules to allow rcu_read_lock()
and rcu_read_unlock() to continue to be used from modules. This
commit therefore adds the needed EXPORT_PER_CPU_SYMBOL_GPL()s.
Reported-by: Paul Gortmaker <paul.gortmaker@windriver.com>
Reported-by: Randy Dunlap <rdunlap@xenotime.net>
Signed-off-by: Paul E. McKenney <paul.mckenney@linaro.org>
Signed-off-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
diff --git a/kernel/rcupdate.c b/kernel/rcupdate.c
index d52c68e..ef83774 100644
--- a/kernel/rcupdate.c
+++ b/kernel/rcupdate.c
@@ -53,7 +53,9 @@
#ifdef CONFIG_PREEMPT_RCU
DEFINE_PER_CPU(int, rcu_read_lock_nesting);
+EXPORT_PER_CPU_SYMBOL_GPL(rcu_read_lock_nesting);
DEFINE_PER_CPU(int, rcu_read_unlock_special);
+EXPORT_PER_CPU_SYMBOL_GPL(rcu_read_unlock_special);
#ifdef CONFIG_PROVE_RCU
DEFINE_PER_CPU(struct task_struct *, rcu_current_task);
#endif /* #ifdef CONFIG_PROVE_RCU */
next prev parent reply other threads:[~2012-04-17 16:32 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-17 4:42 linux-next: Tree for Apr 17 Stephen Rothwell
2012-04-17 18:40 ` linux-next: Tree for Apr 17 (pci-sysfs.c and vga_switcheroo.c) Randy Dunlap
2012-04-25 16:37 ` Bjorn Helgaas
2012-04-25 16:45 ` Matthew Garrett
2012-04-17 18:57 ` linux-next: Tree for Apr 17 (rcu) Randy Dunlap
2012-04-17 16:32 ` Paul E. McKenney [this message]
2012-04-17 20:14 ` Randy Dunlap
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120417163232.GG2404@linux.vnet.ibm.com \
--to=paulmck@linux.vnet.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=paul.gortmaker@windriver.com \
--cc=rdunlap@xenotime.net \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.