All of lore.kernel.org
 help / color / mirror / Atom feed
From: Nils Kassube <kassube@gmx.net>
To: Mauro Carvalho Chehab <mchehab@redhat.com>, linux-media@vger.kernel.org
Subject: [Patch] bttv: Enable radio if the card description has no radio flag but the tuner has FM
Date: Tue, 17 Apr 2012 19:00:38 +0200	[thread overview]
Message-ID: <201204171900.38809.kassube@gmx.net> (raw)

Some bttv cards (e.g. card=24) have a tuner which can receive FM radio 
but the card description doesn't have the has_radio flag set, because 
the description is used for cards with and without FM capability. The 
function bttv_init_tuner can detect the tuner either automatically or by 
insmod option. However the original code only partly uses the detected 
tuner capabilities. While the radio device node is created, the device 
is not usable due to the wrong mode_mask. This patch uses the has_radio 
flag from the detected tuner instead of the card description.

Signed-off-by: Nils Kassube <kassube@gmx.net>

--- media_build/linux/drivers/media/video/bt8xx/bttv-cards.c.orig	
2012-04-17 15:17:55.000000000 +0200
+++ media_build/linux/drivers/media/video/bt8xx/bttv-cards.c	
2012-04-17 15:50:48.000000000 +0200
@@ -3665,7 +3665,7 @@
 		tun_setup.type = btv->tuner_type;
 		tun_setup.addr = addr;
 
-		if (bttv_tvcards[btv->c.type].has_radio)
+		if (btv->has_radio)
 			tun_setup.mode_mask |= T_RADIO;
 
 		bttv_call_all(btv, tuner, s_type_addr, &tun_setup);

                 reply	other threads:[~2012-04-17 17:01 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201204171900.38809.kassube@gmx.net \
    --to=kassube@gmx.net \
    --cc=linux-media@vger.kernel.org \
    --cc=mchehab@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.