Re: [PATCH V2] spi/pl022: Fix range checking for bits per word

[Grant Likely <grant.likely-s3s/WqlpOiPyB63q8FvJNQ@public.gmane.org>]

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain, Size: 909 bytes --]

On Tue, 17 Apr 2012 11:29:37 +0200, Linus Walleij <linus.walleij-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org> wrote:
> On Tue, Apr 17, 2012 at 9:10 AM, Vinit Shenoy <vinit.shenoy-qxv4g6HH51o@public.gmane.org> wrote:
> 
> > pl022 ssp controller supports word lengths from 4 to 16 (or 32) bits.
> > Currently implemented checks were incorrect. It has following check
> >
> > if (pl022->vendor->max_bpw >= 32)
> >
> > which must be checking for <=.
> >
> > Also error print message is incorrect, that prints "range is from 1 to
> > 16".
> >
> > Fix both these issues.
> >
> > Signed-off-by: Vinit Shenoy <vinit.shenoy-qxv4g6HH51o@public.gmane.org>
> > ---
> > V1->V2:
> > - Fixed the check:
> >        if (pl022->vendor->max_bpw >= 32)
> > - Re-written complete range check logic.
> 
> Looks correct to me:
> Acked-by: Linus Walleij <linus.walleij-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>

Applied, thanks

g.



[-- Attachment #2: Type: text/plain, Size: 274 bytes --]

------------------------------------------------------------------------------
Better than sec? Nothing is better than sec when it comes to
monitoring Big Data applications. Try Boundary one-second 
resolution app monitoring today. Free.
http://p.sf.net/sfu/Boundary-dev2dev

[-- Attachment #3: Type: text/plain, Size: 210 bytes --]

_______________________________________________
spi-devel-general mailing list
spi-devel-general-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org
https://lists.sourceforge.net/lists/listinfo/spi-devel-general